chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js - Issue 2250843002: [CUPS] WebUI handler for CUPS printing: Retrieve the printer list from user preference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js

Issue 2250843002: [CUPS] WebUI handler for CUPS printing: Retrieve the printer list from user preference. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address skau@ and dbeam@'s comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h » ('j') | chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js

diff --git a/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js b/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js

index cf8091272d9339fd8e1761a6aa05fb300c48efc2..528050e3c8218615e1fc8716dff088e6677f6124 100644

--- a/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js

+++ b/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js

@@ -17,6 +17,7 @@

* printerStatus: string,

* printerAddress: string,

* printerProtocol: string,

+ * printerQueue: string,

Dan Beam 2016/08/18 21:17:29 is this code actually compiled? i swear @typedef

xdai1 2016/08/18 23:06:40 Oh I didn't know that. Modified as you suggested.

* }}

var CupsPrinterInfo;