Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js

Issue 2250843002: [CUPS] WebUI handler for CUPS printing: Retrieve the printer list from user preference. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address skau@ and dbeam@'s comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview A helper object used from the "CUPS printing" section to 6 * @fileoverview A helper object used from the "CUPS printing" section to
7 * interact with the browser. 7 * interact with the browser.
8 */ 8 */
9 9
10 /** 10 /**
11 * @typedef {{ 11 * @typedef {{
12 * printerId: string, 12 * printerId: string,
13 * printerName: string, 13 * printerName: string,
14 * printerDescription: string, 14 * printerDescription: string,
15 * printerManufacturer: string, 15 * printerManufacturer: string,
16 * printerModel: string, 16 * printerModel: string,
17 * printerStatus: string, 17 * printerStatus: string,
18 * printerAddress: string, 18 * printerAddress: string,
19 * printerProtocol: string, 19 * printerProtocol: string,
20 * printerQueue: string,
Dan Beam 2016/08/18 21:17:29 is this code actually compiled? i swear @typedef
xdai1 2016/08/18 23:06:40 Oh I didn't know that. Modified as you suggested.
20 * }} 21 * }}
21 */ 22 */
22 var CupsPrinterInfo; 23 var CupsPrinterInfo;
23 24
24 /** 25 /**
25 * @typedef {{ 26 * @typedef {{
26 * printerList: !Array<!CupsPrinterInfo>, 27 * printerList: !Array<!CupsPrinterInfo>,
27 * }} 28 * }}
28 */ 29 */
29 var CupsPrintersList; 30 var CupsPrintersList;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 removeCupsPrinter: function(printerId) { 75 removeCupsPrinter: function(printerId) {
75 chrome.send('removeCupsPrinter', [printerId]); 76 chrome.send('removeCupsPrinter', [printerId]);
76 }, 77 },
77 }; 78 };
78 79
79 return { 80 return {
80 CupsPrintersBrowserProxy: CupsPrintersBrowserProxy, 81 CupsPrintersBrowserProxy: CupsPrintersBrowserProxy,
81 CupsPrintersBrowserProxyImpl: CupsPrintersBrowserProxyImpl, 82 CupsPrintersBrowserProxyImpl: CupsPrintersBrowserProxyImpl,
82 }; 83 };
83 }); 84 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698