Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2250823003: [Extension DocServer] Update BranchUtility, README (Closed)

Created:
4 years, 4 months ago by Devlin
Modified:
4 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extension DocServer] Update BranchUtility, README BranchUtility uses Omaha Proxy's version history (https://omahaproxy.appspot.com/history.json?channel=dev&os=win&json=1) to get the set of versions to use, and raises an exception if one fails. However, the version history isn't eternal, and only returns a limited amount. Handle the gracefully and add an ugly hacky assert until we do something better. Also update the README instructions for showing the dev server. BUG=638731 Committed: https://crrev.com/977311fa0e0d3ff8edfbb4ccb5b11b21037e13f0 Cr-Commit-Position: refs/heads/master@{#412641}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update usernames #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M chrome/common/extensions/docs/server2/README View 1 2 chunks +7 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/branch_utility.py View 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
Devlin
Ken, Antony, mind taking a look? We may just end up blowing all this logic ...
4 years, 4 months ago (2016-08-17 00:44:32 UTC) #6
Ken Rockot(use gerrit already)
lgtm On 2016/08/17 at 00:44:32, rdevlin.cronin wrote: > Ken, Antony, mind taking a look? We ...
4 years, 4 months ago (2016-08-17 14:54:59 UTC) #7
asargent_no_longer_on_chrome
lgtm https://codereview.chromium.org/2250823003/diff/1/chrome/common/extensions/docs/server2/README File chrome/common/extensions/docs/server2/README (right): https://codereview.chromium.org/2250823003/diff/1/chrome/common/extensions/docs/server2/README#newcode74 chrome/common/extensions/docs/server2/README:74: Contact kalman@chromium.org or rockot@chromium.org to obtain access. While ...
4 years, 4 months ago (2016-08-17 18:16:32 UTC) #8
Ken Rockot(use gerrit already)
Please replace both names with some current extensions team members. :) On Wed, Aug 17, ...
4 years, 4 months ago (2016-08-17 18:19:41 UTC) #9
Devlin
https://codereview.chromium.org/2250823003/diff/1/chrome/common/extensions/docs/server2/README File chrome/common/extensions/docs/server2/README (right): https://codereview.chromium.org/2250823003/diff/1/chrome/common/extensions/docs/server2/README#newcode74 chrome/common/extensions/docs/server2/README:74: Contact kalman@chromium.org or rockot@chromium.org to obtain access. On 2016/08/17 ...
4 years, 4 months ago (2016-08-17 21:11:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250823003/20001
4 years, 4 months ago (2016-08-17 21:12:01 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 21:23:59 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 21:26:53 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/977311fa0e0d3ff8edfbb4ccb5b11b21037e13f0
Cr-Commit-Position: refs/heads/master@{#412641}

Powered by Google App Engine
This is Rietveld 408576698