|
|
Chromium Code Reviews|
Created:
4 years, 4 months ago by Devlin Modified:
4 years, 4 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Extension DocServer] Update BranchUtility, README
BranchUtility uses Omaha Proxy's version history
(https://omahaproxy.appspot.com/history.json?channel=dev&os=win&json=1)
to get the set of versions to use, and raises an exception if one fails.
However, the version history isn't eternal, and only returns a limited
amount. Handle the gracefully and add an ugly hacky assert until we do
something better.
Also update the README instructions for showing the dev server.
BUG=638731
Committed: https://crrev.com/977311fa0e0d3ff8edfbb4ccb5b11b21037e13f0
Cr-Commit-Position: refs/heads/master@{#412641}
Patch Set 1 #
Total comments: 3
Patch Set 2 : Update usernames #
Messages
Total messages: 22 (14 generated)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rdevlin.cronin@chromium.org changed reviewers: + asargent@chromium.org, rockot@chromium.org
Ken, Antony, mind taking a look? We may just end up blowing all this logic away at some point, but it bothered me that I couldn't build the dev server. https://codereview.chromium.org/2250823003/diff/1/chrome/common/extensions/do... File chrome/common/extensions/docs/server2/README (right): https://codereview.chromium.org/2250823003/diff/1/chrome/common/extensions/do... chrome/common/extensions/docs/server2/README:71: Deploying the Server Ken, do you know if this process is still correct?
lgtm On 2016/08/17 at 00:44:32, rdevlin.cronin wrote: > Ken, Antony, mind taking a look? We may just end up blowing all this logic away at some point, but it bothered me that I couldn't build the dev server. > > https://codereview.chromium.org/2250823003/diff/1/chrome/common/extensions/do... > File chrome/common/extensions/docs/server2/README (right): > > https://codereview.chromium.org/2250823003/diff/1/chrome/common/extensions/do... > chrome/common/extensions/docs/server2/README:71: Deploying the Server > Ken, do you know if this process is still correct? Yes they appear to be correct. It's really just generic instructions for updating a GAE app, with the addition of the build_server.py step to first copy some dependencies from elsewhere in the repo.
lgtm https://codereview.chromium.org/2250823003/diff/1/chrome/common/extensions/do... File chrome/common/extensions/docs/server2/README (right): https://codereview.chromium.org/2250823003/diff/1/chrome/common/extensions/do... chrome/common/extensions/docs/server2/README:74: Contact kalman@chromium.org or rockot@chromium.org to obtain access. While you're in here, you could remove kalman@ from this line =)
Please replace both names with some current extensions team members. :) On Wed, Aug 17, 2016 at 11:16 AM, <asargent@chromium.org> wrote: > lgtm > > > https://codereview.chromium.org/2250823003/diff/1/chrome/ > common/extensions/docs/server2/README > File chrome/common/extensions/docs/server2/README (right): > > https://codereview.chromium.org/2250823003/diff/1/chrome/ > common/extensions/docs/server2/README#newcode74 > chrome/common/extensions/docs/server2/README:74: Contact > kalman@chromium.org or rockot@chromium.org to obtain access. > While you're in here, you could remove kalman@ from this line =) > > https://codereview.chromium.org/2250823003/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Extension DocServer] Update BranchUtility, README BranchUtility uses Omaha Proxy's version history (https://omahaproxy.appspot.com/history.json?channel=dev&os=win&json=1) to get the set of versions to use, and raises an exception if one fails. However, the version history isn't eternal, and only returns a limited amount. Handle the gracefully and add an ugly hacky assert until we do something better. Also update the README instructions for showing the dev server. BUG= ========== to ========== [Extension DocServer] Update BranchUtility, README BranchUtility uses Omaha Proxy's version history (https://omahaproxy.appspot.com/history.json?channel=dev&os=win&json=1) to get the set of versions to use, and raises an exception if one fails. However, the version history isn't eternal, and only returns a limited amount. Handle the gracefully and add an ugly hacky assert until we do something better. Also update the README instructions for showing the dev server. BUG=638731 ==========
https://codereview.chromium.org/2250823003/diff/1/chrome/common/extensions/do... File chrome/common/extensions/docs/server2/README (right): https://codereview.chromium.org/2250823003/diff/1/chrome/common/extensions/do... chrome/common/extensions/docs/server2/README:74: Contact kalman@chromium.org or rockot@chromium.org to obtain access. On 2016/08/17 18:16:32, Antony Sargent wrote: > While you're in here, you could remove kalman@ from this line =) Done. I didn't want to volunteer you/lazyboy/catmullings, so I've polyfilled with "me or another extensions team member".
The CQ bit was checked by rdevlin.cronin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org, asargent@chromium.org Link to the patchset: https://codereview.chromium.org/2250823003/#ps20001 (title: "Update usernames")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Extension DocServer] Update BranchUtility, README BranchUtility uses Omaha Proxy's version history (https://omahaproxy.appspot.com/history.json?channel=dev&os=win&json=1) to get the set of versions to use, and raises an exception if one fails. However, the version history isn't eternal, and only returns a limited amount. Handle the gracefully and add an ugly hacky assert until we do something better. Also update the README instructions for showing the dev server. BUG=638731 ========== to ========== [Extension DocServer] Update BranchUtility, README BranchUtility uses Omaha Proxy's version history (https://omahaproxy.appspot.com/history.json?channel=dev&os=win&json=1) to get the set of versions to use, and raises an exception if one fails. However, the version history isn't eternal, and only returns a limited amount. Handle the gracefully and add an ugly hacky assert until we do something better. Also update the README instructions for showing the dev server. BUG=638731 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Extension DocServer] Update BranchUtility, README BranchUtility uses Omaha Proxy's version history (https://omahaproxy.appspot.com/history.json?channel=dev&os=win&json=1) to get the set of versions to use, and raises an exception if one fails. However, the version history isn't eternal, and only returns a limited amount. Handle the gracefully and add an ugly hacky assert until we do something better. Also update the README instructions for showing the dev server. BUG=638731 ========== to ========== [Extension DocServer] Update BranchUtility, README BranchUtility uses Omaha Proxy's version history (https://omahaproxy.appspot.com/history.json?channel=dev&os=win&json=1) to get the set of versions to use, and raises an exception if one fails. However, the version history isn't eternal, and only returns a limited amount. Handle the gracefully and add an ugly hacky assert until we do something better. Also update the README instructions for showing the dev server. BUG=638731 Committed: https://crrev.com/977311fa0e0d3ff8edfbb4ccb5b11b21037e13f0 Cr-Commit-Position: refs/heads/master@{#412641} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/977311fa0e0d3ff8edfbb4ccb5b11b21037e13f0 Cr-Commit-Position: refs/heads/master@{#412641} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
