Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2250803002: Work around MacOSX driver bug related with glGetFragDataLocation. (Closed)

Created:
4 years, 4 months ago by Zhenyao Mo
Modified:
4 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work around MacOSX driver bug related with glGetFragDataLocation. BUG=638340 TEST=gl_tests R=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/712211c39695d69dcda58ce1cc9c63c3c154b1f6 Cr-Commit-Position: refs/heads/master@{#412355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M gpu/command_buffer/service/feature_info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +12 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Zhenyao Mo
With this CL, conformance2/programs/gl-get-frag-data-locations.html pass on Mac (hasn't rolled in yet, but verified locally). piman: ...
4 years, 4 months ago (2016-08-16 20:30:07 UTC) #4
piman
lgtm
4 years, 4 months ago (2016-08-16 22:08:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250803002/1
4 years, 4 months ago (2016-08-16 22:12:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 22:16:33 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 22:19:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/712211c39695d69dcda58ce1cc9c63c3c154b1f6
Cr-Commit-Position: refs/heads/master@{#412355}

Powered by Google App Engine
This is Rietveld 408576698