Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2250793004: Observatory: Report peak process memory usage. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
zra, Cutch, siva
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Mac in bytes #

Patch Set 3 : Windows include #

Total comments: 2

Patch Set 4 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M runtime/observatory/lib/src/elements/vm_view.html View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/os.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/os_android.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/os_linux.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/os_win.cc View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rmacnak
4 years, 4 months ago (2016-08-17 20:10:07 UTC) #2
Cutch
LGTM with a question about ios https://chromiumcodereview.appspot.com/2250793004/diff/40001/runtime/vm/os_macos.cc File runtime/vm/os_macos.cc (right): https://chromiumcodereview.appspot.com/2250793004/diff/40001/runtime/vm/os_macos.cc#newcode246 runtime/vm/os_macos.cc:246: usage.ru_maxrss = 0; ...
4 years, 4 months ago (2016-08-17 20:13:47 UTC) #3
rmacnak
https://chromiumcodereview.appspot.com/2250793004/diff/40001/runtime/vm/os_macos.cc File runtime/vm/os_macos.cc (right): https://chromiumcodereview.appspot.com/2250793004/diff/40001/runtime/vm/os_macos.cc#newcode246 runtime/vm/os_macos.cc:246: usage.ru_maxrss = 0; On 2016/08/17 20:13:47, Cutch wrote: > ...
4 years, 4 months ago (2016-08-17 20:26:08 UTC) #4
rmacnak
Committed patchset #4 (id:60001) manually as 80e4763a214677ee5a898d666da93dceb2308392 (presubmit successful).
4 years, 4 months ago (2016-08-17 20:38:58 UTC) #6
zra
DBC In the future please also stub out calls on Fuchsia, otherwise the build will ...
4 years, 4 months ago (2016-08-17 22:24:34 UTC) #8
siva
4 years, 4 months ago (2016-08-18 16:47:38 UTC) #10
Message was sent while issue was closed. 
DBC - Need to add an unimplemented in os_fuchsia.cc

Powered by Google App Engine
This is Rietveld 408576698