third_party/WebKit/public/platform/modules/payments/payment_request.mojom - Issue 2250793003: Separate PaymentRequest initialization and display.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Issue 2250793003: Separate PaymentRequest initialization and display. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java ('K') | « third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/payments/payment_request.mojom

diff --git a/third_party/WebKit/public/platform/modules/payments/payment_request.mojom b/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

index 28f741eaabe0600adc193abead86a678c192eba4..d8089b92049f4dc62c357b123d03c99395411034 100644

--- a/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

+++ b/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

@@ -131,9 +131,10 @@ enum PaymentComplete {

interface PaymentRequest {

SetClient(PaymentRequestClient client);

- Show(array<PaymentMethodData> methodData,

+ Init(array<PaymentMethodData> methodData,

Marijn Kruisselbrink 2016/08/22 16:46:15 Would it make sense to pass the PaymentRequestClie

please use gerrit instead 2016/08/22 16:49:32 Good idea. I'm on it.

PaymentDetails details,

PaymentOptions options);

+ Show();

UpdateWith(PaymentDetails details);

Abort();

Complete(PaymentComplete result);