Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: ui/views/controls/button/label_button.cc

Issue 2250783002: Allow InkDropRipple to co-exist with highlight (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl try Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/button/label_button.cc
diff --git a/ui/views/controls/button/label_button.cc b/ui/views/controls/button/label_button.cc
index face3975a2e5901512cbb2fb853e2e128b93b81f..f3cc5c887243952face30d3fa29e8bfee9b2a44b 100644
--- a/ui/views/controls/button/label_button.cc
+++ b/ui/views/controls/button/label_button.cc
@@ -445,10 +445,9 @@ std::unique_ptr<views::InkDropRipple> LabelButton::CreateInkDropRipple() const {
return GetText().empty()
? CreateDefaultInkDropRipple(
image()->GetMirroredBounds().CenterPoint())
- : std::unique_ptr<views::InkDropRipple>(
- new views::FloodFillInkDropRipple(
- GetLocalBounds(), GetInkDropCenterBasedOnLastEvent(),
- GetInkDropBaseColor(), ink_drop_visible_opacity()));
+ : base::WrapUnique(new views::FloodFillInkDropRipple(
bruthig 2016/08/25 17:45:29 I believe the convention is to use MakeUnique().
Evan Stade 2016/08/26 23:36:15 Done.
+ GetLocalBounds(), GetInkDropCenterBasedOnLastEvent(),
+ GetInkDropBaseColor(), ink_drop_visible_opacity()));
}
std::unique_ptr<views::InkDropHighlight> LabelButton::CreateInkDropHighlight()

Powered by Google App Engine
This is Rietveld 408576698