Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Unified Diff: ui/webui/resources/cr_elements/network/cr_network_select.js

Issue 2250773002: WebUI: cr-network-list: Use a single list of cr-network-list-items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add show-separators Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/cr_elements/network/cr_network_select.js
diff --git a/ui/webui/resources/cr_elements/network/cr_network_select.js b/ui/webui/resources/cr_elements/network/cr_network_select.js
index f6edde42bc5ccad70f2e0b861a777b8aec09f7de..eb9e50a24016c9cc34d7af1510d8afca3466b223 100644
--- a/ui/webui/resources/cr_elements/network/cr_network_select.js
+++ b/ui/webui/resources/cr_elements/network/cr_network_select.js
@@ -15,10 +15,7 @@ Polymer({
* Network state for the active network.
* @type {?CrOnc.NetworkStateProperties}
*/
- activeNetworkState: {
- type: Object,
- value: null
- },
+ activeNetworkState: Object,
/**
* If true, the element includes an 'expand' button that toggles the
@@ -26,7 +23,7 @@ Polymer({
*/
expandable: {
type: Boolean,
- value: false
+ value: false,
},
/**
@@ -34,7 +31,7 @@ Polymer({
*/
maxHeight: {
type: Number,
- value: 1000
+ value: 1000,
},
/**
@@ -43,7 +40,7 @@ Polymer({
networkListOpened: {
type: Boolean,
value: true,
- observer: "networkListOpenedChanged_"
+ observer: 'networkListOpenedChanged_',
},
/**
@@ -51,37 +48,49 @@ Polymer({
*/
showActive: {
type: Boolean,
- value: false
+ value: false,
+ reflectToAttribute: true,
+ },
+
+ /**
+ * Show all buttons in list items.
+ */
+ showButtons: {
+ type: Boolean,
+ value: false,
+ reflectToAttribute: true,
+ },
+
+ /**
+ * Show separators between all items.
+ */
+ showSeparators: {
+ type: Boolean,
+ value: false,
+ reflectToAttribute: true,
},
/**
* List of all network state data for all visible networks.
- * See <cr-network-list-network-item/> for details.
- *
* @type {!Array<!CrOnc.NetworkStateProperties>}
*/
networkStateList: {
type: Array,
- value: function() { return []; }
+ value: function() {
+ return [];
+ }
},
/**
- * List of custom items to display at the end of networks list.
- * See <cr-network-list-custom-item/> for details.
- *
- * @type {!Array<Object>}
+ * The list of custom items to display after the list of networks.
+ * See CrNetworkList for details.
+ * @type {!Array<CrNetworkList.CustomItemState>}
*/
customItems: {
type: Array,
- value: function() { return []; },
- },
-
- /**
- * Show all buttons in list items.
- */
- showButtons: {
- type: Boolean,
- value: false,
+ value: function() {
+ return [];
+ },
},
/**
@@ -94,6 +103,7 @@ Polymer({
handleNetworkItemSelected: {
type: Boolean,
value: false,
+ reflectToAttribute: true,
},
},
@@ -162,12 +172,12 @@ Polymer({
* @private
*/
getNetworksCallback_: function(states) {
- this.activeNetworkState = states[0] || null;
+ this.activeNetworkState = states[0] || undefined;
this.networkStateList = states;
},
/**
- * Event triggered when a cr-network-list-network-item is selected.
+ * Event triggered when a cr-network-list-item is selected.
* @param {!{detail: !CrOnc.NetworkStateProperties}} event
* @private
*/
@@ -175,7 +185,7 @@ Polymer({
var state = event.detail;
if (!this.handleNetworkItemSelected) {
- this.fire("network-item-selected", state);
+ this.fire('network-item-selected', state);
return;
}
« no previous file with comments | « ui/webui/resources/cr_elements/network/cr_network_select.html ('k') | ui/webui/resources/cr_elements_resources.grdp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698