ui/webui/resources/cr_elements/network/cr_network_list_types.js - Issue 2250773002: WebUI: cr-network-list: Use a single list of cr-network-list-items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/network/cr_network_list_types.js

Issue 2250773002: WebUI: cr-network-list: Use a single list of cr-network-list-items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add show-separators Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/webui/resources/cr_elements/network/cr_network_list_network_item.js ('k') | ui/webui/resources/cr_elements/network/cr_network_select.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/cr_elements/network/cr_network_list_types.js

diff --git a/ui/webui/resources/cr_elements/network/cr_network_list_types.js b/ui/webui/resources/cr_elements/network/cr_network_list_types.js

index b0c21fba76da1838ae9ec540d155f62c99bf129d..d3e707d20e165d8d40c5e4af36ba5c9645b2c870 100644

--- a/ui/webui/resources/cr_elements/network/cr_network_list_types.js

+++ b/ui/webui/resources/cr_elements/network/cr_network_list_types.js

@@ -4,8 +4,8 @@

/**

* @fileoverview

- *

- * This file contains typedefs <cr-network-list/> properties.

+ * This file contains typedefs properties for CrNetworkList, shared by

+ * CrNetworkListItem.

var CrNetworkList = {};

@@ -14,9 +14,13 @@ var CrNetworkList = {};

* Generic managed property type. This should match any of the basic managed

* types in chrome.networkingPrivate, e.g. networkingPrivate.ManagedBoolean.

* @typedef {{

- * customItemName: (!String|undefined),

- * polymerIcon: (!String|undefined),

+ * customItemName: string,

+ * polymerIcon: (string|undefined),

* customData: (!Object|undefined),

+ * isFirstCustomItem: (boolean|undefined),

* }}

CrNetworkList.CustomItemState;

+/** @typedef {CrOnc.NetworkStateProperties|CrNetworkList.CustomItemState} */

+CrNetworkList.CrNetworkListItemType;