Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2250763002: SkPDF: Font names need escaping (Closed)

Created:
4 years, 4 months ago by hal.canary
Modified:
4 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: Font names need escaping NOTRY=true Committed: https://skia.googlesource.com/skia/+/6c80a9d4b06e10a2865731c487a537d34963268a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pdf/SkPDFFont.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
hal.canary
here's the fix.
4 years, 4 months ago (2016-08-16 18:46:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250763002/1
4 years, 4 months ago (2016-08-16 18:46:34 UTC) #6
robertphillips
lgtm
4 years, 4 months ago (2016-08-16 18:48:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250763002/1
4 years, 4 months ago (2016-08-16 18:54:14 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 18:55:01 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6c80a9d4b06e10a2865731c487a537d34963268a

Powered by Google App Engine
This is Rietveld 408576698