Oilpan: Completely move core/animations/ to oilpan's heap

Source/core/animation/TimedItem.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 33 matching lines @@
     if (fillMode != Timing::FillModeAuto)
         return fillMode;
     if (isAnimation)
         return Timing::FillModeNone;
     return Timing::FillModeBoth;
 }
 
 } // namespace
 
 TimedItem::TimedItem(const Timing& timing, PassOwnPtr<EventDelegate> eventDelegate)
-    : m_parent(0)
+    : m_parent(nullptr)
     , m_startTime(0)
-    , m_player(0)
+    , m_player(nullptr)
     , m_timing(timing)
     , m_eventDelegate(eventDelegate)
     , m_calculated()
     , m_isFirstSample(true)
     , m_needsUpdate(true)
     , m_lastUpdateTime(nullValue())
 {
     m_timing.assertValid();
 }
 
@@ skipping 114 matching lines @@
 const TimedItem::CalculatedTiming& TimedItem::ensureCalculated() const
 {
     if (!m_player)
         return m_calculated;
     if (m_player->outdated())
         m_player->update(AnimationPlayer::UpdateOnDemand);
     ASSERT(!m_player->outdated());
     return m_calculated;
 }
 
-PassRefPtr<TimedItemTiming> TimedItem::timing()
+PassRefPtrWillBeRawPtr<TimedItemTiming> TimedItem::timing()
 {
     return TimedItemTiming::create(this);
 }
 
+void TimedItem::trace(Visitor* visitor)
+{
+    visitor->trace(m_parent);
+    visitor->registerWeakMembers<TimedItem, &TimedItem::processWeakMembers>(this);
+}
+
+void TimedItem::processWeakMembers(Visitor* visitor)
+{
+    if (!visitor->isAlive(m_player) && m_player)

[Mads Ager (chromium), 2014/04/29 10:29:41]

I would turn the condition the other way around and ask for m_player before
asking the visitor if it is alive.

+        detach();
+}
+
 } // namespace WebCore