Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Issue 2250713006: Allow updating arc widget bounds in maximize/fullscreen state. (Closed)

Created:
4 years, 4 months ago by oshima
Modified:
4 years, 4 months ago
Reviewers:
reveman
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Allow updating arc widget bounds in maximize/fullscreen state. ARC window can be pillar/letterboxed in maximized state, and chrome needs to adjust its window to those sizes. BUG=634572 TBR=reveman@chromium.org TEST=WindowStateTest.AllowSetBoundsInMaximized Manually tested on minnie Review-Url: https://codereview.chromium.org/2237983002 Cr-Commit-Position: refs/heads/master@{#412006} (cherry picked from commit e68d9c3c4f704de541d5f796aec4c0bd82e7ee7b) Committed: https://chromium.googlesource.com/chromium/src/+/4c483f1a73d3ca005269f50bfa272abbdf9e2b2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -4 lines) Patch
M ash/common/wm/default_state.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/common/wm/maximize_mode/maximize_mode_window_state.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ash/common/wm/window_state.h View 2 chunks +10 lines, -0 lines 0 comments Download
M ash/wm/window_state_unittest.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M components/exo/shell_surface.cc View 2 chunks +18 lines, -1 line 0 comments Download
M components/exo/shell_surface_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
oshima
4 years, 4 months ago (2016-08-17 23:38:08 UTC) #2
oshima
4 years, 4 months ago (2016-08-17 23:46:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c483f1a73d3ca005269f50bfa272abbdf9e2b2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698