Chromium Code Reviews

Unified Diff: src/objects.h

Issue 2250703003: There are only 2 language modes, not 3 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 1b0ded0aa82eaf2254a3742bc2d07aacefaf9f38..1e7ca72853d19d28282bcb4f13efbc8396eaf505 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -4401,9 +4401,9 @@ class ScopeInfo : public FixedArray {
// Properties of scopes.
class ScopeTypeField : public BitField<ScopeType, 0, 4> {};
class CallsEvalField : public BitField<bool, ScopeTypeField::kNext, 1> {};
- STATIC_ASSERT(LANGUAGE_END == 3);
+ STATIC_ASSERT(LANGUAGE_END == 2);
class LanguageModeField
- : public BitField<LanguageMode, CallsEvalField::kNext, 2> {};
+ : public BitField<LanguageMode, CallsEvalField::kNext, 1> {};
class DeclarationScopeField
: public BitField<bool, LanguageModeField::kNext, 1> {};
class ReceiverVariableField
@@ -7582,7 +7582,7 @@ class SharedFunctionInfo: public HeapObject {
kCompilerHintsCount, // Pseudo entry
};
// Add hints for other modes when they're added.
- STATIC_ASSERT(LANGUAGE_END == 3);
+ STATIC_ASSERT(LANGUAGE_END == 2);
neis 2016/08/17 16:47:34 I can't see why this is here.
Toon Verwaest 2016/08/17 21:26:11 For the comment above. But ok, I'm going to remove
// kFunctionKind has to be byte-aligned
STATIC_ASSERT((kFunctionKind % kBitsPerByte) == 0);
// Make sure that FunctionKind and byte 2 are in sync:

Powered by Google App Engine