src/globals.h - Issue 2250703003: There are only 2 language modes, not 3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/globals.h

Issue 2250703003: There are only 2 language modes, not 3 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/globals.h

diff --git a/src/globals.h b/src/globals.h

index 6fc93d92db2707cc09b0d3ef6f27141513220aa6..ca133ad3dac07402a8e7dcf9134f482aba61dba9 100644

--- a/src/globals.h

+++ b/src/globals.h

@@ -272,8 +272,7 @@ template <typename T, class P = FreeStoreAllocationPolicy> class List;

// The Strict Mode (ECMA-262 5th edition, 4.2.2).

-enum LanguageMode { SLOPPY, STRICT, LANGUAGE_END = 3 };

+enum LanguageMode { SLOPPY, STRICT, LANGUAGE_END = 2 };

neis 2016/08/17 16:47:34 Why do we explicitly write down the number here? T

Toon Verwaest 2016/08/17 21:26:11 Done.

inline std::ostream& operator<<(std::ostream& os, const LanguageMode& mode) {

switch (mode) {

« no previous file with comments | « src/code-stubs.h ('k') | src/ic/ic-state.h » ('j') | src/objects.h » ('J')