Chromium Code Reviews

Issue 2250703003: There are only 2 language modes, not 3 (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
neis, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

There are only 2 language modes, not 3 BUG= Committed: https://crrev.com/39764ba293412adde99a77a66d0750695312e006 Cr-Commit-Position: refs/heads/master@{#38704}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Addressed comments #

Patch Set 3 : Mark languagemode as uint8_t #

Patch Set 4 : Use uint32_t to make hash_value happy #

Unified diffs Side-by-side diffs Stats (+20 lines, -31 lines)
M src/ast/scopes.h View 1 chunk +2 lines, -2 lines 0 comments
M src/code-stubs.h View 1 chunk +2 lines, -2 lines 0 comments
M src/globals.h View 1 chunk +1 line, -2 lines 0 comments
M src/ic/ic-state.h View 1 chunk +2 lines, -2 lines 0 comments
M src/objects.h View 2 chunks +2 lines, -4 lines 0 comments
M src/objects.cc View 2 chunks +5 lines, -12 lines 0 comments
M src/objects-inl.h View 1 chunk +2 lines, -2 lines 0 comments
M src/parsing/parser.h View 1 chunk +1 line, -1 line 0 comments
M src/runtime/runtime.h View 1 chunk +2 lines, -2 lines 0 comments
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +1 line, -2 lines 0 comments

Messages

Total messages: 30 (16 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-17 15:55:37 UTC) #2
neis
lgtm, with comments https://codereview.chromium.org/2250703003/diff/1/src/globals.h File src/globals.h (right): https://codereview.chromium.org/2250703003/diff/1/src/globals.h#newcode275 src/globals.h:275: enum LanguageMode { SLOPPY, STRICT, LANGUAGE_END ...
4 years, 4 months ago (2016-08-17 16:47:34 UTC) #3
neis
lgtm, with comments
4 years, 4 months ago (2016-08-17 16:47:35 UTC) #4
neis
lgtm, with comments
4 years, 4 months ago (2016-08-17 16:47:36 UTC) #5
neis
lgtm, with comments
4 years, 4 months ago (2016-08-17 16:47:36 UTC) #6
neis
Oops, something funky going on with my chromebook.
4 years, 4 months ago (2016-08-17 16:48:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250703003/20001
4 years, 4 months ago (2016-08-17 20:42:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21957)
4 years, 4 months ago (2016-08-17 20:46:16 UTC) #12
Toon Verwaest
addressed comments. marja@ ptal src/parser https://codereview.chromium.org/2250703003/diff/1/src/globals.h File src/globals.h (right): https://codereview.chromium.org/2250703003/diff/1/src/globals.h#newcode275 src/globals.h:275: enum LanguageMode { SLOPPY, ...
4 years, 4 months ago (2016-08-17 21:26:11 UTC) #20
marja
lgtm
4 years, 4 months ago (2016-08-18 08:40:36 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250703003/60001
4 years, 4 months ago (2016-08-18 08:57:20 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-18 08:59:02 UTC) #27
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/39764ba293412adde99a77a66d0750695312e006 Cr-Commit-Position: refs/heads/master@{#38704}
4 years, 4 months ago (2016-08-18 08:59:19 UTC) #29
Michael Hablich
4 years, 4 months ago (2016-08-18 12:02:36 UTC) #30
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2257133002/ by hablich@chromium.org.

The reason for reverting is: Breaks ARM and MIPS builds e.g.
https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20....

Powered by Google App Engine