There are only 2 language modes, not 3

There are only 2 language modes, not 3

BUG=

Committed: https://crrev.com/39764ba293412adde99a77a66d0750695312e006
Cr-Commit-Position: refs/heads/master@{#38704}

[Toon Verwaest, 2016-08-17 15:55:37]

verwaest@chromium.org changed reviewers:
+ neis@chromium.org

[Toon Verwaest, 2016-08-17 15:55:37]

ptal

[neis, 2016-08-17 16:47:34]

lgtm, with comments

https://codereview.chromium.org/2250703003/diff/1/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/2250703003/diff/1/src/globals.h#newcode275
src/globals.h:275: enum LanguageMode { SLOPPY, STRICT, LANGUAGE_END = 2 };
Why do we explicitly write down the number here? That's why we didn't notice
earlier that some things should be updated.

https://codereview.chromium.org/2250703003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2250703003/diff/1/src/objects.cc#newcode9169
src/objects.cc:9169: }
Maybe get rid of the switch.

https://codereview.chromium.org/2250703003/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2250703003/diff/1/src/objects.h#newcode7585
src/objects.h:7585: STATIC_ASSERT(LANGUAGE_END == 2);
I can't see why this is here.

[neis, 2016-08-17 16:47:35]

lgtm, with comments

[neis, 2016-08-17 16:47:36]

lgtm, with comments

[neis, 2016-08-17 16:47:36]

lgtm, with comments

[neis, 2016-08-17 16:48:16]

Oops, something funky going on with my chromebook.

[Toon Verwaest, 2016-08-17 20:41:59]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-08-17 20:41:59]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2250703003/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-08-17 20:42:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 20:46:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 20:46:16]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21957)

[Toon Verwaest, 2016-08-17 21:06:49]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 21:06:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 21:10:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 21:10:30]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Toon Verwaest, 2016-08-17 21:13:11]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 21:13:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Toon Verwaest, 2016-08-17 21:26:10]

verwaest@chromium.org changed reviewers:
+ marja@chromium.org

[Toon Verwaest, 2016-08-17 21:26:11]

addressed comments.
marja@ ptal src/parser

https://codereview.chromium.org/2250703003/diff/1/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/2250703003/diff/1/src/globals.h#newcode275
src/globals.h:275: enum LanguageMode { SLOPPY, STRICT, LANGUAGE_END = 2 };
On 2016/08/17 16:47:34, neis wrote:
> Why do we explicitly write down the number here? That's why we didn't notice
> earlier that some things should be updated.

Done.

https://codereview.chromium.org/2250703003/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2250703003/diff/1/src/objects.h#newcode7585
src/objects.h:7585: STATIC_ASSERT(LANGUAGE_END == 2);
On 2016/08/17 16:47:34, neis wrote:
> I can't see why this is here.

For the comment above. But ok, I'm going to remove it.

[commit-bot: I haz the power, 2016-08-17 21:55:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 21:55:59]

Dry run: This issue passed the CQ dry run.

[marja, 2016-08-18 08:40:36]

lgtm

[Toon Verwaest, 2016-08-18 08:57:17]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-08-18 08:57:17]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2250703003/#ps60001
(title: "Use uint32_t to make hash_value happy")

[commit-bot: I haz the power, 2016-08-18 08:57:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 08:59:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-18 08:59:18]

Description was changed from

==========
There are only 2 language modes, not 3

BUG=
==========

to

==========
There are only 2 language modes, not 3

BUG=

Committed: https://crrev.com/39764ba293412adde99a77a66d0750695312e006
Cr-Commit-Position: refs/heads/master@{#38704}
==========

[commit-bot: I haz the power, 2016-08-18 08:59:19]

Patchset 4 (id:??) landed as
https://crrev.com/39764ba293412adde99a77a66d0750695312e006
Cr-Commit-Position: refs/heads/master@{#38704}

[Michael Hablich, 2016-08-18 12:02:36]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2257133002/ by hablich@chromium.org.

The reason for reverting is: Breaks ARM and MIPS builds e.g.
https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug%20....