Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2250683003: Add test for platform encoders, turn off platform encoders by default (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add test for platform encoders, turn off platform encoders by default Clients that like WIC and CG can still use them. And we can be confident about that, since we now test WIC and CG. Let Skia always use our own encoders by default, so we can do cool, custom things on all platforms. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2250683003 Committed: https://skia.googlesource.com/skia/+/36931c2b47f81db7ccf441937567c6fda72ad3e6

Patch Set 1 #

Patch Set 2 : Tested on Mac #

Patch Set 3 : Test on windows #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -42 lines) Patch
A gm/encode-platform.cpp View 1 2 1 chunk +121 lines, -0 lines 0 comments Download
M gyp/images.gyp View 1 4 chunks +1 line, -8 lines 0 comments Download
M include/core/SkImageEncoder.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/images/SkForceLinking.cpp View 1 1 chunk +9 lines, -11 lines 0 comments Download
M src/ports/SkImageEncoder_CG.cpp View 1 2 2 chunks +5 lines, -8 lines 0 comments Download
M src/ports/SkImageEncoder_WIC.cpp View 1 2 4 chunks +5 lines, -13 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 14 (10 generated)
msarett
https://codereview.chromium.org/2250683003/diff/60001/src/ports/SkImageEncoder_WIC.cpp File src/ports/SkImageEncoder_WIC.cpp (left): https://codereview.chromium.org/2250683003/diff/60001/src/ports/SkImageEncoder_WIC.cpp#oldcode70 src/ports/SkImageEncoder_WIC.cpp:70: case kBMP_Type: These don't work. I'm guessing that they've ...
4 years, 4 months ago (2016-08-16 21:26:51 UTC) #5
reed1
lgtm
4 years, 4 months ago (2016-08-16 21:34:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250683003/60001
4 years, 4 months ago (2016-08-16 22:10:29 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 22:11:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://skia.googlesource.com/skia/+/36931c2b47f81db7ccf441937567c6fda72ad3e6

Powered by Google App Engine
This is Rietveld 408576698