Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 2250623004: gn: make gn gen preserve import statements passed in --args (Closed)

Created:
4 years, 4 months ago by tsniatowski
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: make gn gen preserve import statements passed in --args Previously, gn gen would expand all imports and only record the final arg keyvalue pairs in args.gn, if called as gn gen --args='import...'. Now the actual import statement will be recorded. This allows avoiding a manual args.gn edit of you want an actual import statement there, for example if the imported gni houses a predefined set of default args that you want to follow, and want to re-gn when it changes. R=brettw@chromium.org,dpranke@chromium.org BUG=588513 Committed: https://crrev.com/9f58d6d943aa2c6bd32be6dbe85a130b8c75efe5 Cr-Commit-Position: refs/heads/master@{#412687}

Patch Set 1 #

Patch Set 2 : order #

Total comments: 2

Patch Set 3 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
A tools/gn/command_format.h View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M tools/gn/command_format.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gn/command_format_unittest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M tools/gn/setup.cc View 1 2 5 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tsniatowski
PTAL
4 years, 4 months ago (2016-08-17 21:50:10 UTC) #1
brettw
Thanks! LGTM https://codereview.chromium.org/2250623004/diff/20001/tools/gn/command_format.h File tools/gn/command_format.h (right): https://codereview.chromium.org/2250623004/diff/20001/tools/gn/command_format.h#newcode1 tools/gn/command_format.h:1: // Copyright 2014 The Chromium Authors. All ...
4 years, 4 months ago (2016-08-17 22:10:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250623004/40001
4 years, 4 months ago (2016-08-17 22:32:34 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-17 23:23:36 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 23:25:22 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9f58d6d943aa2c6bd32be6dbe85a130b8c75efe5
Cr-Commit-Position: refs/heads/master@{#412687}

Powered by Google App Engine
This is Rietveld 408576698