gn: make gn gen preserve import statements passed in --args

gn: make gn gen preserve import statements passed in --args

Previously, gn gen would expand all imports and only record the final
arg keyvalue pairs in args.gn, if called as gn gen --args='import...'.

Now the actual import statement will be recorded. This allows avoiding
a manual args.gn edit of you want an actual import statement there, for
example if the imported gni houses a predefined set of default args
that you want to follow, and want to re-gn when it changes.

R=brettw@chromium.org,dpranke@chromium.org
BUG=588513
Committed: https://crrev.com/9f58d6d943aa2c6bd32be6dbe85a130b8c75efe5
Cr-Commit-Position: refs/heads/master@{#412687}

[tsniatowski, 2016-08-17 21:50:10]

PTAL

[brettw, 2016-08-17 22:10:02]

Thanks! LGTM

https://codereview.chromium.org/2250623004/diff/20001/tools/gn/command_format.h
File tools/gn/command_format.h (right):

https://codereview.chromium.org/2250623004/diff/20001/tools/gn/command_format...
tools/gn/command_format.h:1: // Copyright 2014 The Chromium Authors. All rights
reserved.
Use current year.

https://codereview.chromium.org/2250623004/diff/20001/tools/gn/setup.cc
File tools/gn/setup.cc (right):

https://codereview.chromium.org/2250623004/diff/20001/tools/gn/setup.cc#newco...
tools/gn/setup.cc:445: // set soure dir so relative imports in args work
Style guide: Comments should be sentences with caps & periods.

[tsniatowski, 2016-08-17 22:32:11]

The CQ bit was checked by tsniatowski@opera.com

[tsniatowski, 2016-08-17 22:32:12]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2250623004/#ps40001
(title: "fixes")

[commit-bot: I haz the power, 2016-08-17 22:32:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 23:23:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-17 23:25:21]

Description was changed from

==========
gn: make gn gen preserve import statements passed in --args

Previously, gn gen would expand all imports and only record the final
arg keyvalue pairs in args.gn, if called as gn gen --args='import...'.

Now the actual import statement will be recorded. This allows avoiding
a manual args.gn edit of you want an actual import statement there, for
example if the imported gni houses a predefined set of default args
that you want to follow, and want to re-gn when it changes.

R=brettw@chromium.org,dpranke@chromium.org
BUG=588513
==========

to

==========
gn: make gn gen preserve import statements passed in --args

Previously, gn gen would expand all imports and only record the final
arg keyvalue pairs in args.gn, if called as gn gen --args='import...'.

Now the actual import statement will be recorded. This allows avoiding
a manual args.gn edit of you want an actual import statement there, for
example if the imported gni houses a predefined set of default args
that you want to follow, and want to re-gn when it changes.

R=brettw@chromium.org,dpranke@chromium.org
BUG=588513

Committed: https://crrev.com/9f58d6d943aa2c6bd32be6dbe85a130b8c75efe5
Cr-Commit-Position: refs/heads/master@{#412687}
==========

[commit-bot: I haz the power, 2016-08-17 23:25:22]

Patchset 3 (id:??) landed as
https://crrev.com/9f58d6d943aa2c6bd32be6dbe85a130b8c75efe5
Cr-Commit-Position: refs/heads/master@{#412687}