Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 2250623003: Keep ServiceWorkerMetrics::Site in ServiceWorkerVersion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index 530900c0a184d5d8452ca29f1e3d82bf8980ae2e..23455e6171ccec1fd1999833721b03feb5892901 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -148,11 +148,10 @@ class CONTENT_EXPORT ServiceWorkerVersion
FetchHandlerExistence fetch_handler_existence() const {
return fetch_handler_existence_;
}
- void set_fetch_handler_existence(FetchHandlerExistence existence) {
- DCHECK_EQ(fetch_handler_existence_, FetchHandlerExistence::UNKNOWN);
- DCHECK_NE(existence, FetchHandlerExistence::UNKNOWN);
- fetch_handler_existence_ = existence;
- }
+ // This also updates |site_for_uma_| when it was Site::OTHER.
+ void set_fetch_handler_existence(FetchHandlerExistence existence);
+
+ bool should_exclude_from_uma() const { return should_exclude_from_uma_; }
const std::vector<GURL>& foreign_fetch_scopes() const {
return foreign_fetch_scopes_;
@@ -168,6 +167,8 @@ class CONTENT_EXPORT ServiceWorkerVersion
foreign_fetch_origins_ = origins;
}
+ ServiceWorkerMetrics::Site site_for_uma() const { return site_for_uma_; }
+
// This sets the new status and also run status change callbacks
// if there're any (see RegisterStatusChangeCallback).
void SetStatus(Status status);
@@ -679,6 +680,7 @@ class CONTENT_EXPORT ServiceWorkerVersion
std::vector<GURL> foreign_fetch_scopes_;
std::vector<url::Origin> foreign_fetch_origins_;
FetchHandlerExistence fetch_handler_existence_;
+ ServiceWorkerMetrics::Site site_for_uma_;
Status status_ = NEW;
std::unique_ptr<EmbeddedWorkerInstance> embedded_worker_;

Powered by Google App Engine
This is Rietveld 408576698