Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: content/browser/service_worker/service_worker_controllee_request_handler.cc

Issue 2250623003: Keep ServiceWorkerMetrics::Site in ServiceWorkerVersion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_metrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_controllee_request_handler.cc
diff --git a/content/browser/service_worker/service_worker_controllee_request_handler.cc b/content/browser/service_worker/service_worker_controllee_request_handler.cc
index bc5770780ea15d3a16c3de9a5cc3e48d3c924719..e12c224c015060c76f997b96b39362959f18ca57 100644
--- a/content/browser/service_worker/service_worker_controllee_request_handler.cc
+++ b/content/browser/service_worker/service_worker_controllee_request_handler.cc
@@ -287,9 +287,7 @@ void ServiceWorkerControlleeRequestHandler::
ServiceWorkerVersion::FetchHandlerExistence::UNKNOWN);
ServiceWorkerMetrics::CountControlledPageLoad(
- stripped_url_, active_version->fetch_handler_existence() ==
- ServiceWorkerVersion::FetchHandlerExistence::EXISTS,
- is_main_frame_load_);
+ active_version->site_for_uma(), stripped_url_, is_main_frame_load_);
bool is_forwarded =
MaybeForwardToServiceWorker(job_.get(), active_version.get());
@@ -321,9 +319,7 @@ void ServiceWorkerControlleeRequestHandler::OnVersionStatusChanged(
DCHECK_NE(version->fetch_handler_existence(),
ServiceWorkerVersion::FetchHandlerExistence::UNKNOWN);
ServiceWorkerMetrics::CountControlledPageLoad(
- stripped_url_, version->fetch_handler_existence() ==
- ServiceWorkerVersion::FetchHandlerExistence::EXISTS,
- is_main_frame_load_);
+ version->site_for_uma(), stripped_url_, is_main_frame_load_);
provider_host_->AssociateRegistration(registration,
false /* notify_controllerchange */);
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698