content/browser/service_worker/service_worker_url_request_job.cc - Issue 2250623003: Keep ServiceWorkerMetrics::Site in ServiceWorkerVersion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_url_request_job.cc

Issue 2250623003: Keep ServiceWorkerMetrics::Site in ServiceWorkerVersion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: diff from https://codereview.chromium.org/2251633002/#ps40001 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_metrics.cc ('k') | content/browser/service_worker/service_worker_version.h » ('j') | content/browser/service_worker/service_worker_version.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_url_request_job.cc

diff --git a/content/browser/service_worker/service_worker_url_request_job.cc b/content/browser/service_worker/service_worker_url_request_job.cc

index c69bc87efbda43e9e323c6b7e8319970108d142e..ca6f09a0f6834cc4b6fb48646ed5f60b9aa00106 100644

--- a/content/browser/service_worker/service_worker_url_request_job.cc

+++ b/content/browser/service_worker/service_worker_url_request_job.cc

@@ -679,8 +679,10 @@ void ServiceWorkerURLRequestJob::DidPrepareFetchEvent(

initial_worker_status_ != EmbeddedWorkerStatus::RUNNING) {

return;

}

- if (ServiceWorkerMetrics::ShouldExcludeURLFromHistogram(request()->url()))

+ if (ServiceWorkerMetrics::ShouldExcludeSiteFromHistogram(

+ version->site_for_uma())) {

return;

+ }

ServiceWorkerMetrics::RecordActivatedWorkerPreparationTimeForMainFrame(

worker_ready_time_ - request()->creation_time(), initial_worker_status_,

version->embedded_worker()->start_situation());