Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2250593002: Simplify Scroll Anchoring Corner Tests. (Closed)

Created:
4 years, 4 months ago by ymalik
Modified:
4 years, 4 months ago
Reviewers:
skobes
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify Scroll Anchoring Corner Tests. The old tests would become irrelevant with the SANACLAP proposal. BUG=637626 Committed: https://crrev.com/f031d2a3e0b8e3d1e8cebe0e859262550137e406 Cr-Commit-Position: refs/heads/master@{#412272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -102 lines) Patch
M third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp View 2 chunks +43 lines, -102 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ymalik
4 years, 4 months ago (2016-08-16 02:11:59 UTC) #2
skobes
lgtm
4 years, 4 months ago (2016-08-16 16:40:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250593002/1
4 years, 4 months ago (2016-08-16 17:20:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 17:24:38 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 17:27:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f031d2a3e0b8e3d1e8cebe0e859262550137e406
Cr-Commit-Position: refs/heads/master@{#412272}

Powered by Google App Engine
This is Rietveld 408576698