[telemetry] Wire TsProxy through telemetry's network stack.

[telemetry] Wire TsProxy through telemetry's network stack.

*** NOTE *** please do not revert this CL as it's causing failure on Windows in the catapult roll. I am looking into fixing the failure.

This patch makes all the network access of Chrome browser
under test go through the ts_proxy server.

When a platform instance in telemetry is initiated, we set up
a ts_proxy_server for that platform & forward the ts_proxy's 
port when the platform is remote platform.

For any newly created instance of WPR, we route the 
ts_proxy_server' outbounds to that WPR server's ports.

Traffic between Chrome & static local server will also go 
through ts_proxy_server but doesn't require any extra 
code for routing because ts_proxy automatically routes 
"localhost://*" url to the right host.

Any Chrome instance to be started will be routed to either
ts_proxy_server' port or its corresponding forwarded port.

ts_proxy_server is only killed when telemetry process ends.

BUG=catapult:#2584

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9fcccf0b65703994c9541273f00a993806a95356

[nednguyen, 2016-08-16 18:22:29]

Description was changed from

==========
[telemetry] Wire TsProxy through telemetry's network stack.

BUG=catapult:#2584
==========

to

==========
[telemetry] Wire TsProxy through telemetry's network stack.

This patch makes all the network access of Chrome browser
under test go through the ts_proxy server.

When a platform instance in telemetry is initiated, we set up
a ts_proxy_server for that platform & forward the ts_proxy's 
port when the platform is remote platform.

For any newly created instance of WPR, we route the 
ts_proxy_server' outbounds to that WPR server's ports.

Traffic between Chrome & static local server will also go 
through ts_proxy_server but doesn't require any extra 
code for routing because ts_proxy automatically routes 
"localhost://*" url to the right host.

Any Chrome instance to be started will be routed to either
ts_proxy_server' port or its corresponding forwarded port.

ts_proxy_server is only killed when telemetry process ends.

BUG=catapult:#2584
==========

[nednguyen, 2016-08-16 18:52:54]

nednguyen@google.com changed reviewers:
+ pmeenan@chromium.org

[nednguyen, 2016-08-16 18:52:55]

Patching this in chromium/src/third_party/catapult is still failing. I am wonder
whether the dynamically mapping outbound ports is not working properly.

https://codereview.chromium.org/2250583004/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
(left):

https://codereview.chromium.org/2250583004/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py:108: if
self.browser_options.no_proxy_server:
This is to be removed in a different CL.

[nednguyen, 2016-08-17 12:38:35]

Patchset #2 (id:20001) has been deleted

[nednguyen, 2016-08-17 12:39:07]

On 2016/08/16 18:52:55, nednguyen wrote:
> Patching this in chromium/src/third_party/catapult is still failing. I am
wonder
> whether the dynamically mapping outbound ports is not working properly.
> 
>
https://codereview.chromium.org/2250583004/diff/1/telemetry/telemetry/interna...
> File telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
> (left):
> 
>
https://codereview.chromium.org/2250583004/diff/1/telemetry/telemetry/interna...
> telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py:108: if
> self.browser_options.no_proxy_server:
> This is to be removed in a different CL.

It works now. Turn out that I forgot to set the desthost for ts_proxy. This CL
is now ready for review.

[nednguyen, 2016-08-17 12:40:09]

nednguyen@google.com changed reviewers:
+ achuith@chromium.org, bccheng@chromium.org

[nednguyen, 2016-08-17 12:41:05]

On 2016/08/17 12:39:07, nednguyen wrote:
> On 2016/08/16 18:52:55, nednguyen wrote:
> > Patching this in chromium/src/third_party/catapult is still failing. I am
> wonder
> > whether the dynamically mapping outbound ports is not working properly.
> > 
> >
>
https://codereview.chromium.org/2250583004/diff/1/telemetry/telemetry/interna...
> > File telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
> > (left):
> > 
> >
>
https://codereview.chromium.org/2250583004/diff/1/telemetry/telemetry/interna...
> > telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py:108:
if
> > self.browser_options.no_proxy_server:
> > This is to be removed in a different CL.
> 
> It works now. Turn out that I forgot to set the desthost for ts_proxy. This CL
> is now ready for review.

CC'ed chromeOS folks since this may break CrOS but I don't have a test cros
machine to try this out. Can you try this CL & points out the places that need
to be fixed?

[Pat Meenan, 2016-08-17 12:59:10]

lgtm

When this lands make sure the perf sheriffs are aware in case the page cycler
stats move.

[bccheng, 2016-08-17 13:08:37]

On 2016/08/17 12:41:05, nednguyen wrote:
> On 2016/08/17 12:39:07, nednguyen wrote:
> > On 2016/08/16 18:52:55, nednguyen wrote:
> > > Patching this in chromium/src/third_party/catapult is still failing. I am
> > wonder
> > > whether the dynamically mapping outbound ports is not working properly.
> > > 
> > >
> >
>
https://codereview.chromium.org/2250583004/diff/1/telemetry/telemetry/interna...
> > > File
telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
> > > (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/2250583004/diff/1/telemetry/telemetry/interna...
> > >
telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py:108:
> if
> > > self.browser_options.no_proxy_server:
> > > This is to be removed in a different CL.
> > 
> > It works now. Turn out that I forgot to set the desthost for ts_proxy. This
CL
> > is now ready for review.
> 
> CC'ed chromeOS folks since this may break CrOS but I don't have a test cros
> machine to try this out. Can you try this CL & points out the places that need
> to be fixed?

Thanks for the heads-up and I will give it a try. Any suggested command to run?

[nednguyen, 2016-08-17 13:22:07]

On 2016/08/17 13:08:37, bccheng wrote:
> On 2016/08/17 12:41:05, nednguyen wrote:
> > On 2016/08/17 12:39:07, nednguyen wrote:
> > > On 2016/08/16 18:52:55, nednguyen wrote:
> > > > Patching this in chromium/src/third_party/catapult is still failing. I
am
> > > wonder
> > > > whether the dynamically mapping outbound ports is not working properly.
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/2250583004/diff/1/telemetry/telemetry/interna...
> > > > File
> telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
> > > > (left):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/2250583004/diff/1/telemetry/telemetry/interna...
> > > >
> telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py:108:
> > if
> > > > self.browser_options.no_proxy_server:
> > > > This is to be removed in a different CL.
> > > 
> > > It works now. Turn out that I forgot to set the desthost for ts_proxy.
This
> CL
> > > is now ready for review.
> > 
> > CC'ed chromeOS folks since this may break CrOS but I don't have a test cros
> > machine to try this out. Can you try this CL & points out the places that
need
> > to be fixed?
> 
> Thanks for the heads-up and I will give it a try. Any suggested command to
run?

I would patch this to chromium/src/third_party/catapult and try:
./tools/perf/run_benchmark smoothness.top_25_smooth ..<other cros flags> (for
checking pages served by WPR)
./tools/perf/run_benchmark media.tough_video_cases ..<other cros flags> (for
checking pages served by memory cache server)

[nednguyen, 2016-08-17 13:50:04]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 13:50:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 14:02:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 14:02:48]

Dry run: Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[nednguyen, 2016-08-17 14:11:49]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 14:11:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 14:22:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 14:22:10]

Dry run: Try jobs failed on following builders:
  Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)

[nednguyen, 2016-08-17 15:32:37]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 15:32:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 15:45:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 15:45:30]

Dry run: Try jobs failed on following builders:
  Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)

[nednguyen, 2016-08-17 18:32:53]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 18:33:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 18:58:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 18:58:54]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2016-08-17 19:12:25]

https://codereview.chromium.org/2250583004/diff/100001/telemetry/telemetry/in...
File
telemetry/telemetry/internal/platform/network_controller_backend_unittest.py
(left):

https://codereview.chromium.org/2250583004/diff/100001/telemetry/telemetry/in...
telemetry/telemetry/internal/platform/network_controller_backend_unittest.py:1:
# Copyright 2014 The Chromium Authors. All rights reserved.
Removed this test file because the tests are badly written & basically are
change-guarding test. Better tests should exercise the code path end-to-end,
which existing tests like page_run_end_to_end & browser_test_cases already
cover.

[bccheng, 2016-08-18 08:11:41]

Test failed on Samus:

[  FAILED  ] video.html?src=crowd.wav&type=audio (5302 ms)

Traceback (most recent call last):
  RunBenchmark at
/work/chromium2/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:318
    benchmark.ShouldTearDownStateAfterEachStorySetRun())
  Run at
/work/chromium2/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:227
    _RunStoryAndProcessErrorIfNeeded(story, results, state, test)
  _RunStoryAndProcessErrorIfNeeded at
/work/chromium2/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:79
    state.WillRunStory(story)
  WillRunStory at
/work/chromium2/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py:219
    self._StartBrowser(page)
  _StartBrowser at
/work/chromium2/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py:179
    self._browser = self._possible_browser.Create(self._finder_options)
  Create at
/work/chromium2/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py:52
    browser_backend, self._platform_backend, self._credentials_path)
  __init__ at
/work/chromium2/src/third_party/catapult/telemetry/telemetry/internal/browser/browser.py:55
    self._browser_backend.Start()
  Start at
/work/chromium2/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py:123
    forwarders.PortPairs(
AttributeError: 'module' object has no attribute 'PortPairs'

[nednguyen, 2016-08-18 12:46:22]

Thanks Ben. Can you try the tests again with the latest patch?

[nednguyen, 2016-08-18 12:48:08]

https://codereview.chromium.org/2250583004/diff/120001/telemetry/telemetry/in...
File telemetry/telemetry/internal/forwarders/cros_forwarder.py (right):

https://codereview.chromium.org/2250583004/diff/120001/telemetry/telemetry/in...
telemetry/telemetry/internal/forwarders/cros_forwarder.py:20: def Create(self,
port_pair, use_remote_port_forwarding=True):
+Achuith, Ben: can you review this part?

[bccheng, 2016-08-19 09:19:53]

lgtm

The latest patch passes on Chromebook now.

[nednguyen, 2016-08-19 10:26:20]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2016-08-19 10:26:21]

The patchset sent to the CQ was uploaded after l-g-t-m from pmeenan@chromium.org
Link to the patchset: https://codereview.chromium.org/2250583004/#ps120001
(title: "CrOS fix?")

[commit-bot: I haz the power, 2016-08-19 10:26:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 10:53:23]

Description was changed from

==========
[telemetry] Wire TsProxy through telemetry's network stack.

This patch makes all the network access of Chrome browser
under test go through the ts_proxy server.

When a platform instance in telemetry is initiated, we set up
a ts_proxy_server for that platform & forward the ts_proxy's 
port when the platform is remote platform.

For any newly created instance of WPR, we route the 
ts_proxy_server' outbounds to that WPR server's ports.

Traffic between Chrome & static local server will also go 
through ts_proxy_server but doesn't require any extra 
code for routing because ts_proxy automatically routes 
"localhost://*" url to the right host.

Any Chrome instance to be started will be routed to either
ts_proxy_server' port or its corresponding forwarded port.

ts_proxy_server is only killed when telemetry process ends.

BUG=catapult:#2584
==========

to

==========
[telemetry] Wire TsProxy through telemetry's network stack.

This patch makes all the network access of Chrome browser
under test go through the ts_proxy server.

When a platform instance in telemetry is initiated, we set up
a ts_proxy_server for that platform & forward the ts_proxy's 
port when the platform is remote platform.

For any newly created instance of WPR, we route the 
ts_proxy_server' outbounds to that WPR server's ports.

Traffic between Chrome & static local server will also go 
through ts_proxy_server but doesn't require any extra 
code for routing because ts_proxy automatically routes 
"localhost://*" url to the right host.

Any Chrome instance to be started will be routed to either
ts_proxy_server' port or its corresponding forwarded port.

ts_proxy_server is only killed when telemetry process ends.

BUG=catapult:#2584

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-08-19 10:53:24]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[nednguyen(REVIEW IN OTHER ACC), 2016-08-19 13:39:38]

Description was changed from

==========
[telemetry] Wire TsProxy through telemetry's network stack.

This patch makes all the network access of Chrome browser
under test go through the ts_proxy server.

When a platform instance in telemetry is initiated, we set up
a ts_proxy_server for that platform & forward the ts_proxy's 
port when the platform is remote platform.

For any newly created instance of WPR, we route the 
ts_proxy_server' outbounds to that WPR server's ports.

Traffic between Chrome & static local server will also go 
through ts_proxy_server but doesn't require any extra 
code for routing because ts_proxy automatically routes 
"localhost://*" url to the right host.

Any Chrome instance to be started will be routed to either
ts_proxy_server' port or its corresponding forwarded port.

ts_proxy_server is only killed when telemetry process ends.

BUG=catapult:#2584

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

to

==========
[telemetry] Wire TsProxy through telemetry's network stack.

*** NOTE *** please do not revert this CL as it's causing failure on Windows in
the catapult roll. I am looking into fixing the failure.

This patch makes all the network access of Chrome browser
under test go through the ts_proxy server.

When a platform instance in telemetry is initiated, we set up
a ts_proxy_server for that platform & forward the ts_proxy's 
port when the platform is remote platform.

For any newly created instance of WPR, we route the 
ts_proxy_server' outbounds to that WPR server's ports.

Traffic between Chrome & static local server will also go 
through ts_proxy_server but doesn't require any extra 
code for routing because ts_proxy automatically routes 
"localhost://*" url to the right host.

Any Chrome instance to be started will be routed to either
ts_proxy_server' port or its corresponding forwarded port.

ts_proxy_server is only killed when telemetry process ends.

BUG=catapult:#2584

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========