Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2250553002: Associate SuspendableTimer with frame's timer task queue. (Closed)

Created:
4 years, 4 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Associate SuspendableTimer with frame's timer task queue. BUG=624694 Committed: https://crrev.com/2bce9cb8f98aaed076e6129966aaf38a9f001fd1 Cr-Commit-Position: refs/heads/master@{#422165}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/SuspendableTimer.cpp View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 26 (18 generated)
dcheng
4 years, 4 months ago (2016-08-16 01:47:12 UTC) #6
haraken
LGTM
4 years, 4 months ago (2016-08-16 02:39:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250553002/1
4 years, 4 months ago (2016-08-16 02:50:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/261669)
4 years, 4 months ago (2016-08-16 03:26:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250553002/40001
4 years, 2 months ago (2016-09-30 16:47:56 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-30 18:50:02 UTC) #23
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/2bce9cb8f98aaed076e6129966aaf38a9f001fd1 Cr-Commit-Position: refs/heads/master@{#422165}
4 years, 2 months ago (2016-09-30 18:52:28 UTC) #25
dcheng
4 years, 2 months ago (2016-10-01 01:46:25 UTC) #26
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2382333003/ by dcheng@chromium.org.

The reason for reverting is: This is just a test..

Powered by Google App Engine
This is Rietveld 408576698