Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2250543004: Revert of Start using vertex attributes for nine-patch blurred rrect draws (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Start using vertex attributes for nine-patch blurred rrect draws (patchset #8 id:140001 of https://codereview.chromium.org/2245653002/ ) Reason for revert: ?? Original issue's description: > Start using vertex attributes for nine-patch blurred rrect draws > > Calved off: > https://codereview.chromium.org/2243133002/ (Pull handling of blurred circles out of GrRRectBlurEffect::Make) > https://codereview.chromium.org/2249463002/ (Update blurred rrect mask filter creation method to also handle caching) > https://codereview.chromium.org/2248533002/ (Update ComputeBlurredRRectParams to compute all the parameters needed for occluded blurred rrect ninepatch draws) > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2245653002 > > Committed: https://skia.googlesource.com/skia/+/087905a730241939da320092543c19dc06d5a7b4 TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/287e7cb936f06634cadf1c6d908dc677012c996b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -70 lines) Patch
M src/effects/SkBlurMaskFilter.cpp View 5 chunks +51 lines, -70 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
robertphillips
Created Revert of Start using vertex attributes for nine-patch blurred rrect draws
4 years, 4 months ago (2016-08-16 22:49:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250543004/1
4 years, 4 months ago (2016-08-16 22:49:15 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 22:49:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/287e7cb936f06634cadf1c6d908dc677012c996b

Powered by Google App Engine
This is Rietveld 408576698