core/fpdfapi/fpdf_parser/include/cpdf_name.h - Issue 2250533002: Fix stack overflow in object Clone() functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/include/cpdf_name.h

Issue 2250533002: Fix stack overflow in object Clone() functions (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase again Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/include/cpdf_name.h

diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_name.h b/core/fpdfapi/fpdf_parser/include/cpdf_name.h

index 523238c8920bdfe29021159029bb6e6b4af6c716..3cefa7e8c1511235abc566d5a643fbabc2f047a1 100644

--- a/core/fpdfapi/fpdf_parser/include/cpdf_name.h

+++ b/core/fpdfapi/fpdf_parser/include/cpdf_name.h

@@ -15,7 +15,7 @@ class CPDF_Name : public CPDF_Object {

// CPDF_Object.

Type GetType() const override;

- CPDF_Object* Clone(FX_BOOL bDirect = FALSE) const override;

+ CPDF_Object* Clone() const override;

CFX_ByteString GetString() const override;

CFX_WideString GetUnicodeText() const override;

void SetString(const CFX_ByteString& str) override;