core/fpdfapi/fpdf_parser/cpdf_boolean.h - Issue 2250533002: Fix stack overflow in object Clone() functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_boolean.h

Issue 2250533002: Fix stack overflow in object Clone() functions (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase again Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_boolean.h

diff --git a/core/fpdfapi/fpdf_parser/cpdf_boolean.h b/core/fpdfapi/fpdf_parser/cpdf_boolean.h

index adbb721f35181c710e74311e78eb58a0a83b25cf..231b8fe9a4eff7daebd8c1129c7c48bb533f519f 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_boolean.h

+++ b/core/fpdfapi/fpdf_parser/cpdf_boolean.h

@@ -18,7 +18,7 @@ class CPDF_Boolean : public CPDF_Object {

// CPDF_Object.

Type GetType() const override;

- CPDF_Object* Clone(FX_BOOL bDirect = FALSE) const override;

+ CPDF_Object* Clone() const override;

CFX_ByteString GetString() const override;

int GetInteger() const override;

void SetString(const CFX_ByteString& str) override;