fpdfsdk/fpdfppo.cpp - Issue 2250533002: Fix stack overflow in object Clone() functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfppo.cpp

Issue 2250533002: Fix stack overflow in object Clone() functions (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: change due to rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfppo.cpp

diff --git a/fpdfsdk/fpdfppo.cpp b/fpdfsdk/fpdfppo.cpp

index 97fd390cb3ccbb28f628e95660752795e4f48c6c..186d92508c6a6e0eb549836b83cfec38b134fa41 100644

--- a/fpdfsdk/fpdfppo.cpp

+++ b/fpdfsdk/fpdfppo.cpp

@@ -407,6 +407,6 @@ DLLEXPORT FPDF_BOOL STDCALL FPDF_CopyViewerPreferences(FPDF_DOCUMENT dest_doc,

if (!pDstDict)

return FALSE;

- pDstDict->SetAt("ViewerPreferences", pSrcDict->Clone(TRUE));

+ pDstDict->SetAt("ViewerPreferences", pSrcDict->CloneDeRef(true));

return TRUE;

}