Fix stack overflow in object Clone() functions

core/fpdfapi/fpdf_parser/include/cpdf_array.h

Index: core/fpdfapi/fpdf_parser/include/cpdf_array.h
diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_array.h b/core/fpdfapi/fpdf_parser/include/cpdf_array.h
index 9bb99da05359f3b1d53f3a3e77038294424e516b..6fc3a401eb17bf1a696e5fc9762f11e5428f3e1c 100644
--- a/core/fpdfapi/fpdf_parser/include/cpdf_array.h
+++ b/core/fpdfapi/fpdf_parser/include/cpdf_array.h
@@ -7,6 +7,7 @@
 #ifndef CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_ARRAY_H_
 #define CORE_FPDFAPI_FPDF_PARSER_INCLUDE_CPDF_ARRAY_H_
 
+#include <set>
 #include <vector>
 
 #include "core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h"
@@ -23,7 +24,7 @@ class CPDF_Array : public CPDF_Object {
 
   // CPDF_Object.
   Type GetType() const override;
-  CPDF_Object* Clone(FX_BOOL bDirect = FALSE) const override;
+  CPDF_Object* Clone() const override;
   bool IsArray() const override;
   CPDF_Array* AsArray() override;
   const CPDF_Array* AsArray() const override;
@@ -67,6 +68,9 @@ class CPDF_Array : public CPDF_Object {
 
  protected:
   ~CPDF_Array() override;

[Lei Zhang, 2016/08/18 15:16:44]

nit: Separator between ctor/dtor and other methods. Ditto in other headers.

[Wei Li, 2016/08/18 22:02:30]

Done.

+  CPDF_Object* CloneWithCheck(
+      bool bDirect,
+      std::set<const CPDF_Object*>* pVisited) const override;
 
   std::vector<CPDF_Object*> m_Objects;
 };