Fix stack overflow in object Clone() functions

core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp

Index: core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp
diff --git a/core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp b/core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp
index 0d3e68e86fc957df77f4464d6070ef53d1d97c2a..1391926e6a6cbe8c1f4140cdc1213af0a0b31954 100644
--- a/core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp
+++ b/core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp
@@ -13,7 +13,7 @@ CPDF_IndirectObjectHolder::CPDF_IndirectObjectHolder() : m_LastObjNum(0) {}
 
 CPDF_IndirectObjectHolder::~CPDF_IndirectObjectHolder() {
   for (const auto& pair : m_IndirectObjs)
-    pair.second->Destroy();
+    pair.second->Release();

[dsinclair, 2016/08/18 14:04:31]

I believe this should be Destroy(). The Release() method in CPDF_Object won't
actually do anything if there is an object number assigned. So, we'd end up
leaking all of the objects.

[Wei Li, 2016/08/18 22:02:30]

You are right, done.

 }
 
 CPDF_Object* CPDF_IndirectObjectHolder::GetIndirectObject(