Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: fpdfsdk/fpdfppo.cpp

Issue 2250533002: Fix stack overflow in object Clone() functions (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebase again Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfdoc/cpdf_interform.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "public/fpdf_ppo.h" 7 #include "public/fpdf_ppo.h"
8 8
9 #include <map> 9 #include <map>
10 #include <memory> 10 #include <memory>
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 400
401 CPDF_Dictionary* pSrcDict = pSrcDoc->GetRoot(); 401 CPDF_Dictionary* pSrcDict = pSrcDoc->GetRoot();
402 pSrcDict = pSrcDict->GetDictBy("ViewerPreferences"); 402 pSrcDict = pSrcDict->GetDictBy("ViewerPreferences");
403 if (!pSrcDict) 403 if (!pSrcDict)
404 return FALSE; 404 return FALSE;
405 405
406 CPDF_Dictionary* pDstDict = pDstDoc->GetRoot(); 406 CPDF_Dictionary* pDstDict = pDstDoc->GetRoot();
407 if (!pDstDict) 407 if (!pDstDict)
408 return FALSE; 408 return FALSE;
409 409
410 pDstDict->SetAt("ViewerPreferences", pSrcDict->Clone(TRUE)); 410 pDstDict->SetAt("ViewerPreferences", pSrcDict->CloneDirectObject());
411 return TRUE; 411 return TRUE;
412 } 412 }
OLDNEW
« no previous file with comments | « core/fpdfdoc/cpdf_interform.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698