Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: core/fpdfapi/fpdf_parser/cpdf_string.cpp

Issue 2250533002: Fix stack overflow in object Clone() functions (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebase again Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_stream.cpp ('k') | core/fpdfapi/fpdf_parser/include/cpdf_array.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/fpdfapi/fpdf_parser/include/cpdf_string.h" 7 #include "core/fpdfapi/fpdf_parser/include/cpdf_string.h"
8 8
9 #include "core/fpdfapi/fpdf_parser/include/fpdf_parser_decode.h" 9 #include "core/fpdfapi/fpdf_parser/include/fpdf_parser_decode.h"
10 10
11 CPDF_String::CPDF_String() : m_bHex(FALSE) {} 11 CPDF_String::CPDF_String() : m_bHex(FALSE) {}
12 12
13 CPDF_String::CPDF_String(const CFX_ByteString& str, FX_BOOL bHex) 13 CPDF_String::CPDF_String(const CFX_ByteString& str, FX_BOOL bHex)
14 : m_String(str), m_bHex(bHex) {} 14 : m_String(str), m_bHex(bHex) {}
15 15
16 CPDF_String::CPDF_String(const CFX_WideString& str) : m_bHex(FALSE) { 16 CPDF_String::CPDF_String(const CFX_WideString& str) : m_bHex(FALSE) {
17 m_String = PDF_EncodeText(str); 17 m_String = PDF_EncodeText(str);
18 } 18 }
19 19
20 CPDF_String::~CPDF_String() {} 20 CPDF_String::~CPDF_String() {}
21 21
22 CPDF_Object::Type CPDF_String::GetType() const { 22 CPDF_Object::Type CPDF_String::GetType() const {
23 return STRING; 23 return STRING;
24 } 24 }
25 25
26 CPDF_Object* CPDF_String::Clone(FX_BOOL bDirect) const { 26 CPDF_Object* CPDF_String::Clone() const {
27 return new CPDF_String(m_String, m_bHex); 27 return new CPDF_String(m_String, m_bHex);
28 } 28 }
29 29
30 CFX_ByteString CPDF_String::GetString() const { 30 CFX_ByteString CPDF_String::GetString() const {
31 return m_String; 31 return m_String;
32 } 32 }
33 33
34 void CPDF_String::SetString(const CFX_ByteString& str) { 34 void CPDF_String::SetString(const CFX_ByteString& str) {
35 m_String = str; 35 m_String = str;
36 } 36 }
37 37
38 bool CPDF_String::IsString() const { 38 bool CPDF_String::IsString() const {
39 return true; 39 return true;
40 } 40 }
41 41
42 CPDF_String* CPDF_String::AsString() { 42 CPDF_String* CPDF_String::AsString() {
43 return this; 43 return this;
44 } 44 }
45 45
46 const CPDF_String* CPDF_String::AsString() const { 46 const CPDF_String* CPDF_String::AsString() const {
47 return this; 47 return this;
48 } 48 }
49 49
50 CFX_WideString CPDF_String::GetUnicodeText() const { 50 CFX_WideString CPDF_String::GetUnicodeText() const {
51 return PDF_DecodeText(m_String); 51 return PDF_DecodeText(m_String);
52 } 52 }
OLDNEW
« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_stream.cpp ('k') | core/fpdfapi/fpdf_parser/include/cpdf_array.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698