Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: core/fpdfapi/fpdf_parser/cpdf_object.cpp

Issue 2250533002: Fix stack overflow in object Clone() functions (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebase again Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 PDFium Authors. All rights reserved. 1 // Copyright 2016 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/fpdfapi/fpdf_parser/include/cpdf_object.h" 7 #include "core/fpdfapi/fpdf_parser/include/cpdf_object.h"
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
11 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h" 11 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h"
12 #include "core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h" 12 #include "core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h"
13 #include "core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h" 13 #include "core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h"
14 #include "core/fpdfapi/fpdf_parser/include/cpdf_parser.h" 14 #include "core/fpdfapi/fpdf_parser/include/cpdf_parser.h"
15 #include "core/fpdfapi/fpdf_parser/include/fpdf_parser_decode.h" 15 #include "core/fpdfapi/fpdf_parser/include/fpdf_parser_decode.h"
16 #include "core/fxcrt/include/fx_string.h" 16 #include "core/fxcrt/include/fx_string.h"
17 #include "third_party/base/stl_util.h" 17 #include "third_party/base/stl_util.h"
18 18
19 CPDF_Object::~CPDF_Object() {} 19 CPDF_Object::~CPDF_Object() {}
20 20
21 CPDF_Object* CPDF_Object::GetDirect() const { 21 CPDF_Object* CPDF_Object::GetDirect() const {
22 return const_cast<CPDF_Object*>(this); 22 return const_cast<CPDF_Object*>(this);
23 } 23 }
24 24
25 CPDF_Object* CPDF_Object::CloneObjectNonCyclic(bool bDirect) const {
26 std::set<const CPDF_Object*> visited_objs;
27 return CloneNonCyclic(bDirect, &visited_objs);
28 }
29
30 CPDF_Object* CPDF_Object::CloneDirectObject() const {
31 return CloneObjectNonCyclic(true);
32 }
33
34 CPDF_Object* CPDF_Object::CloneNonCyclic(
35 bool bDirect,
36 std::set<const CPDF_Object*>* pVisited) const {
37 return Clone();
38 }
39
25 void CPDF_Object::Release() { 40 void CPDF_Object::Release() {
26 if (m_ObjNum) 41 if (m_ObjNum)
27 return; 42 return;
28 43
29 Destroy(); 44 Destroy();
30 } 45 }
31 46
32 CFX_ByteString CPDF_Object::GetString() const { 47 CFX_ByteString CPDF_Object::GetString() const {
33 return CFX_ByteString(); 48 return CFX_ByteString();
34 } 49 }
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 return nullptr; 156 return nullptr;
142 } 157 }
143 158
144 CPDF_String* CPDF_Object::AsString() { 159 CPDF_String* CPDF_Object::AsString() {
145 return nullptr; 160 return nullptr;
146 } 161 }
147 162
148 const CPDF_String* CPDF_Object::AsString() const { 163 const CPDF_String* CPDF_Object::AsString() const {
149 return nullptr; 164 return nullptr;
150 } 165 }
OLDNEW
« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_number.cpp ('k') | core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698