core/fpdfapi/fpdf_parser/cpdf_null.h - Issue 2250533002: Fix stack overflow in object Clone() functions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/fpdfapi/fpdf_parser/cpdf_null.h

Issue 2250533002: Fix stack overflow in object Clone() functions (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase again Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_name.cpp ('k') | core/fpdfapi/fpdf_parser/cpdf_null.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2016 PDFium Authors. All rights reserved.	1 // Copyright 2016 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef CORE_FPDFAPI_FPDF_PARSER_CPDF_NULL_H_	7 #ifndef CORE_FPDFAPI_FPDF_PARSER_CPDF_NULL_H_

8 #define CORE_FPDFAPI_FPDF_PARSER_CPDF_NULL_H_	8 #define CORE_FPDFAPI_FPDF_PARSER_CPDF_NULL_H_

9	9

10 #include "core/fpdfapi/fpdf_parser/include/cpdf_object.h"	10 #include "core/fpdfapi/fpdf_parser/include/cpdf_object.h"

11	11

12 class CPDF_Null : public CPDF_Object {	12 class CPDF_Null : public CPDF_Object {

13 public:	13 public:

14 CPDF_Null();	14 CPDF_Null();

15	15

16 // CPDF_Object.	16 // CPDF_Object.

17 Type GetType() const override;	17 Type GetType() const override;

18 CPDF_Object* Clone(FX_BOOL bDirect = FALSE) const override;	18 CPDF_Object* Clone() const override;

19 };	19 };

20	20

21 #endif // CORE_FPDFAPI_FPDF_PARSER_CPDF_NULL_H_	21 #endif // CORE_FPDFAPI_FPDF_PARSER_CPDF_NULL_H_

OLD	NEW