Fix stack overflow in object Clone() functions

core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h"
 
 #include "core/fpdfapi/fpdf_parser/cpdf_boolean.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h"
@@ skipping 26 matching lines @@
 }
 
 CPDF_Dictionary* CPDF_Dictionary::AsDictionary() {
   return this;
 }
 
 const CPDF_Dictionary* CPDF_Dictionary::AsDictionary() const {
   return this;
 }
 
-CPDF_Object* CPDF_Dictionary::Clone(FX_BOOL bDirect) const {
+CPDF_Object* CPDF_Dictionary::Clone() const {
+  return CloneDeRef(false);
+}
+
+CPDF_Object* CPDF_Dictionary::CloneWithCheck(
+    bool bDirect,
+    std::set<const CPDF_Object*>* pVisited) const {
+  pVisited->insert(this);
   CPDF_Dictionary* pCopy = new CPDF_Dictionary();
-  for (const auto& it : *this)
-    pCopy->m_Map.insert(std::make_pair(it.first, it.second->Clone(bDirect)));
+  for (const auto& it : *this) {
+    auto value = it.second;

[Lei Zhang, 2016/08/18 15:16:44]

auto* ?

[Wei Li, 2016/08/18 22:02:30]

Changed to actual type

+    if (!pdfium::ContainsKey(*pVisited, value))

[dsinclair, 2016/08/18 14:04:31]

nit: add {}'s

[Wei Li, 2016/08/18 22:02:30]

Done.

+      pCopy->m_Map.insert(
+          std::make_pair(it.first, value->CloneWithCheck(bDirect, pVisited)));
+  }
   return pCopy;
 }
 
 CPDF_Object* CPDF_Dictionary::GetObjectBy(const CFX_ByteString& key) const {
   auto it = m_Map.find(key);
   return it != m_Map.end() ? it->second : nullptr;
 }
 
 CPDF_Object* CPDF_Dictionary::GetDirectObjectBy(
     const CFX_ByteString& key) const {
@@ skipping 175 matching lines @@
                                   const CFX_Matrix& matrix) {
   CPDF_Array* pArray = new CPDF_Array;
   pArray->AddNumber(matrix.a);
   pArray->AddNumber(matrix.b);
   pArray->AddNumber(matrix.c);
   pArray->AddNumber(matrix.d);
   pArray->AddNumber(matrix.e);
   pArray->AddNumber(matrix.f);
   SetAt(key, pArray);
 }