ServiceWorker should have an interface object.

ServiceWorker should have an interface object.

BUG=361828
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171386

[dominicc (has gone to gerrit), 2014-04-11 06:55:05]

PTAL

This assumes https://codereview.chromium.org/231513003/ goes first.

[jsbell, 2014-04-11 15:54:09]

lgtm with notes...

https://codereview.chromium.org/225053005/diff/20001/LayoutTests/fast/service...
File LayoutTests/fast/serviceworker/serviceworker-interface-expected.txt
(right):

https://codereview.chromium.org/225053005/diff/20001/LayoutTests/fast/service...
LayoutTests/fast/serviceworker/serviceworker-interface-expected.txt:1: This is a
testharness.js-based test.
Interesting... the "expected" files for the tests I touched didn't have this.

https://codereview.chromium.org/225053005/diff/20001/LayoutTests/fast/service...
File LayoutTests/fast/serviceworker/serviceworker-interface.html (right):

https://codereview.chromium.org/225053005/diff/20001/LayoutTests/fast/service...
LayoutTests/fast/serviceworker/serviceworker-interface.html:8:
assert_throws(null, function() { new ServiceWorker(); },
Can you add a case that calls the constructor as function (i.e. w/o new), just
`ServiceWorker()` ? Should also fail.

[dominicc (has gone to gerrit), 2014-04-11 18:41:12]

Thanks!

On 2014/04/11 15:54:09, jsbell wrote:
> lgtm with notes...
> 
>
https://codereview.chromium.org/225053005/diff/20001/LayoutTests/fast/service...
> File LayoutTests/fast/serviceworker/serviceworker-interface-expected.txt
> (right):
> 
>
https://codereview.chromium.org/225053005/diff/20001/LayoutTests/fast/service...
> LayoutTests/fast/serviceworker/serviceworker-interface-expected.txt:1: This is
a
> testharness.js-based test.
> Interesting... the "expected" files for the tests I touched didn't have this.

I think this is generated by testharnessreport.js.

>
https://codereview.chromium.org/225053005/diff/20001/LayoutTests/fast/service...
> File LayoutTests/fast/serviceworker/serviceworker-interface.html (right):
> 
>
https://codereview.chromium.org/225053005/diff/20001/LayoutTests/fast/service...
> LayoutTests/fast/serviceworker/serviceworker-interface.html:8:
> assert_throws(null, function() { new ServiceWorker(); },
> Can you add a case that calls the constructor as function (i.e. w/o new), just
> `ServiceWorker()` ? Should also fail.

Good point, done!

[dominicc (has gone to gerrit), 2014-04-11 18:41:17]

The CQ bit was checked by dominicc@chromium.org

[commit-bot: I haz the power, 2014-04-11 18:41:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominicc@chromium.org/225053005/40001

[commit-bot: I haz the power, 2014-04-11 18:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-11 18:51:47]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[dominicc (has gone to gerrit), 2014-04-11 20:16:25]

+falken for ServiceWorker OWNERS.

[falken, 2014-04-11 20:23:57]

lg but I'm not an OWNER. you need +kinuko or +michaeln

[falken, 2014-04-11 20:28:02]

On 2014/04/11 20:23:57, falken wrote:
> lg but I'm not an OWNER. you need +kinuko or +michaeln

actually there's a real test failure. looks like you must rebaseline:
webexposed/global-constructors-listing.html

[dominicc (has gone to gerrit), 2014-04-11 21:14:33]

On 2014/04/11 20:28:02, falken wrote:
> On 2014/04/11 20:23:57, falken wrote:
> > lg but I'm not an OWNER. you need +kinuko or +michaeln
> 
> actually there's a real test failure. looks like you must rebaseline:
> webexposed/global-constructors-listing.html

I'll investigate. This shouldn't be webexposed (yet) so I must have messed up.

[dominicc (has gone to gerrit), 2014-04-11 22:08:56]

On 2014/04/11 21:14:33, dominicc wrote:
> On 2014/04/11 20:28:02, falken wrote: 
> > actually there's a real test failure. looks like you must rebaseline:
> > webexposed/global-constructors-listing.html
> 
> I'll investigate. This shouldn't be webexposed (yet) so I must have messed up.

michaeln: PTAL for ServiceWorker OWNERS.

I rebaselined the test. Rebaselining is OK in this case, we do want this
constructor to show up in webexposed, but not virtual/stable/webexposed. (Thanks
Matt!)

[michaeln, 2014-04-11 22:10:25]

rs lgtm

[jsbell, 2014-04-11 23:11:27]

> > Interesting... the "expected" files for the tests I touched didn't have
this.
> 
> I think this is generated by testharnessreport.js.

Oh, fun. It's one of the differences between:

LayoutTests/resources/testharnessreport.js

and

LayoutTests/http/tests/resources/testharnessreport.js

I'll follow up with dpranke.

[dominicc (has gone to gerrit), 2014-04-12 00:23:46]

The CQ bit was checked by dominicc@chromium.org

[commit-bot: I haz the power, 2014-04-12 00:24:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominicc@chromium.org/225053005/60001

[commit-bot: I haz the power, 2014-04-12 00:35:36]

Change committed as 171386