Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: chrome/browser/ui/views/app_list/linux/app_list_linux.h

Issue 225053004: Refactor views app list services to allow more code sharing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase+sim30 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/app_list/linux/app_list_linux.h
diff --git a/chrome/browser/ui/views/app_list/linux/app_list_linux.h b/chrome/browser/ui/views/app_list/linux/app_list_linux.h
index 68046d3d68106279409689c8cfa6c20600aa3d97..e12d2c6870d163b300a70f05d28b45a409425ae3 100644
--- a/chrome/browser/ui/views/app_list/linux/app_list_linux.h
+++ b/chrome/browser/ui/views/app_list/linux/app_list_linux.h
@@ -5,10 +5,7 @@
#ifndef CHROME_BROWSER_UI_VIEWS_APP_LIST_LINUX_APP_LIST_LINUX_H_
#define CHROME_BROWSER_UI_VIEWS_APP_LIST_LINUX_APP_LIST_LINUX_H_
-#include "base/callback.h"
-#include "chrome/browser/ui/app_list/app_list.h"
#include "chrome/browser/ui/app_list/app_list_positioner.h"
-#include "ui/app_list/views/app_list_view_observer.h"
namespace app_list {
class AppListView;
@@ -20,16 +17,10 @@ class Point;
class Size;
} // namespace gfx
-// Responsible for positioning, hiding and showing an AppListView on Linux.
-// This includes watching window activation/deactivation messages to determine
-// if the user has clicked away from it.
-class AppListLinux : public AppList,
- public app_list::AppListViewObserver {
+// Responsible for positioning an AppListView on Linux.
+// TODO(tapted): Shouldn't be a class - move the static member functions out.
+class AppListLinux {
public:
- AppListLinux(app_list::AppListView* view,
- const base::Closure& on_should_dismiss);
- virtual ~AppListLinux();
-
// Determines which screen edge the shelf is aligned to. This tries to find
// the edge of the surface where the user normally launches apps from (so, for
// example, on Gnome Classic, this is the applications menu, not the taskbar).
@@ -46,27 +37,7 @@ class AppListLinux : public AppList,
const gfx::Point& cursor,
AppListPositioner::ScreenEdge edge);
- // AppList:
- virtual void Show() OVERRIDE;
- virtual void Hide() OVERRIDE;
- virtual void MoveNearCursor() OVERRIDE;
- virtual bool IsVisible() OVERRIDE;
- virtual void Prerender() OVERRIDE;
- virtual gfx::NativeWindow GetWindow() OVERRIDE;
- virtual void SetProfile(Profile* profile) OVERRIDE;
-
- // app_list::AppListViewObserver:
- virtual void OnActivationChanged(views::Widget* widget, bool active) OVERRIDE;
-
- private:
- // Weak pointer. The view manages its own lifetime.
- app_list::AppListView* view_;
- bool window_icon_updated_;
-
- // Called to request |view_| be closed.
- base::Closure on_should_dismiss_;
-
- DISALLOW_COPY_AND_ASSIGN(AppListLinux);
+ static void MoveNearCursor(app_list::AppListView* view);
};
#endif // CHROME_BROWSER_UI_VIEWS_APP_LIST_LINUX_APP_LIST_LINUX_H_

Powered by Google App Engine
This is Rietveld 408576698