chrome/chrome_browser_ui.gypi - Issue 225053004: Refactor views app list services to allow more code sharing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 225053004: Refactor views app list services to allow more code sharing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Windows is the worst Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/app_list/win/activation_tracker_win.cc ('K') | « chrome/browser/ui/views/app_list/win/app_list_win.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index 47a8836a24bdf0fc81bfa1107e33b1a695777b41..c36903d1fcefdb8eacf6435ed636f76dc444bdb3 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -135,12 +135,12 @@

'browser/ui/app_list/app_context_menu.cc',

'browser/ui/app_list/app_context_menu.h',

'browser/ui/app_list/app_context_menu_delegate.h',

- 'browser/ui/app_list/app_list.h',

'browser/ui/app_list/app_list_controller_delegate.cc',

'browser/ui/app_list/app_list_controller_delegate.h',

'browser/ui/app_list/app_list_controller_delegate_impl.cc',

'browser/ui/app_list/app_list_controller_delegate_impl.h',

- 'browser/ui/app_list/app_list_factory.h',

+ 'browser/ui/app_list/app_list_controller_delegate_views.cc',

+ 'browser/ui/app_list/app_list_controller_delegate_views.h',

'browser/ui/app_list/app_list_icon_win.cc',

'browser/ui/app_list/app_list_icon_win.h',

'browser/ui/app_list/app_list_positioner.cc',

@@ -152,8 +152,11 @@

'browser/ui/app_list/app_list_service_impl.h',

'browser/ui/app_list/app_list_service_mac.h',

'browser/ui/app_list/app_list_service_mac.mm',

- 'browser/ui/app_list/app_list_shower.cc',

- 'browser/ui/app_list/app_list_shower.h',

+ 'browser/ui/app_list/app_list_service_views.cc',

+ 'browser/ui/app_list/app_list_service_views.h',

+ 'browser/ui/app_list/app_list_shower_delegate.h',

+ 'browser/ui/app_list/app_list_shower_views.cc',

+ 'browser/ui/app_list/app_list_shower_views.h',

'browser/ui/app_list/app_list_syncable_service.cc',

'browser/ui/app_list/app_list_syncable_service.h',

'browser/ui/app_list/app_list_syncable_service_factory.cc',

@@ -1433,8 +1436,6 @@

'browser/ui/views/accessibility/invert_bubble_view.h',

'browser/ui/views/accessibility/automation_manager_views.cc',

'browser/ui/views/accessibility/automation_manager_views.h',

- 'browser/ui/views/app_list/linux/app_list_controller_delegate_linux.cc',

- 'browser/ui/views/app_list/linux/app_list_controller_delegate_linux.h',

'browser/ui/views/app_list/linux/app_list_linux.cc',

'browser/ui/views/app_list/linux/app_list_linux.h',

'browser/ui/views/app_list/linux/app_list_service_linux.cc',