chrome/browser/ui/app_list/app_list_factory.h - Issue 225053004: Refactor views app list services to allow more code sharing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/app_list/app_list_factory.h

Issue 225053004: Refactor views app list services to allow more code sharing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: oops - fix some names Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_controller_delegate_views.cc ('k') | chrome/browser/ui/app_list/app_list_service_views.h » ('j') | chrome/browser/ui/app_list/app_list_service_views.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
Matt Giuca 2014/04/29 03:52:51 I'm confused about this, is it Reitveld's fault? I'm confused about this, is it Reitveld's fault? This file, along with app_list_shower and app_list_shower_unittest, have been entirely erased, but Reitveld shows them as M instead of D. Have the files actually been deleted, or just emptied? tapted 2014/04/29 04:20:30 I blame rietveld. The raw diff has Index: chrome/ Show quoted text On 2014/04/29 03:52:51, Matt Giuca wrote: > I'm confused about this, is it Reitveld's fault? > > This file, along with app_list_shower and app_list_shower_unittest, have been > entirely erased, but Reitveld shows them as M instead of D. Have the files > actually been deleted, or just emptied? I blame rietveld. The raw diff has Index: chrome/browser/ui/app_list/app_list_factory.h diff --git a/chrome/browser/ui/app_list/app_list_factory.h b/chrome/browser/ui/app_list/app_list_factory.h deleted file mode 100644 Uploading to a new CL might convince Rietveld to do the right thing.
2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 #ifndef CHROME_BROWSER_UI_APP_LIST_APP_LIST_FACTORY_H_

6 #define CHROME_BROWSER_UI_APP_LIST_APP_LIST_FACTORY_H_

7

8 #include "base/callback_forward.h"

9 #include "chrome/browser/ui/app_list/app_list.h"

10

11 class AppListService;

12 class Profile;

13

14 namespace app_list {

15 class PaginationModel;

16 }

17

18 // Factory for AppLists. Used to allow us to create fake app lists in tests.

19 class AppListFactory {

20 public:

21 virtual ~AppListFactory() {}

22 virtual AppList* CreateAppList(Profile* profile,

23 AppListService* service,

24 const base::Closure& on_should_dismiss) = 0;

25 };

26

27 #endif // CHROME_BROWSER_UI_APP_LIST_APP_LIST_FACTORY_H_

OLD	NEW