third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 2250523003: Implement SANACLAP (http://bit.ly/sanaclap).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2250523003: Implement SANACLAP (http://bit.ly/sanaclap). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: improve comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index 20681097384728f6e84ccc056967ab3512b3b711..09be9cb5a6e1b0fb64fe10169c42d5cff08f3dea 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -503,6 +503,11 @@ StyleDifference ComputedStyle::visualInvalidationDiff(const ComputedStyle& other

updatePropertySpecificDifferences(other, diff);

+ // TODO(skobes): Refine the criteria for ScrollAnchor-disabling properties.

+ // Some things set needsLayout but shouldn't disable scroll anchoring.

+ if (diff.needsLayout() || diff.transformChanged())

+ diff.setScrollAnchorDisablingPropertyChanged();

// Cursors are not checked, since they will be set appropriately in response to mouse events,

// so they don't need to cause any paint invalidation or layout.