Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2250513005: [interpreter] Record type feedback in the handlers for Inc and Dec. (Closed)

Created:
4 years, 4 months ago by epertoso
Modified:
4 years, 4 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Record type feedback in the handlers for Inc and Dec. BUG=v8:5273 R=rmcilroy@chromium.org Committed: https://crrev.com/6949acab5cd0adb733855ed6f1478e4f7ebb03a4 Cr-Commit-Position: refs/heads/master@{#38751}

Patch Set 1 #

Patch Set 2 : Added tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -11 lines) Patch
M src/code-stubs.h View 1 3 chunks +15 lines, -2 lines 0 comments Download
M src/code-stubs.cc View 9 chunks +36 lines, -4 lines 0 comments Download
M src/compiler/bytecode-graph-builder.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 chunks +17 lines, -3 lines 0 comments Download
M src/interpreter/interpreter.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 2 chunks +14 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 1 chunk +223 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
epertoso
4 years, 4 months ago (2016-08-18 12:50:26 UTC) #4
rmcilroy
LGTM, with one request: Could you add a similar test as the bitwise operators for ...
4 years, 4 months ago (2016-08-18 13:01:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250513005/20001
4 years, 4 months ago (2016-08-19 12:34:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-19 12:58:51 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 12:59:06 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6949acab5cd0adb733855ed6f1478e4f7ebb03a4
Cr-Commit-Position: refs/heads/master@{#38751}

Powered by Google App Engine
This is Rietveld 408576698