Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2250513004:
Convert blimp_browsertests to run on Swarming. (Closed)
|
Created:
4 years, 4 months ago by M-A Ruel Modified:
4 years, 4 months ago CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionConvert blimp_browsertests to run on Swarming.
tools/mb/mb.py run //out/Release -j 500 -m chromium.linux -b "Linux Builder"
blimp_browsertests
R=kmarshall@chromium.org
BUG=98637
Committed: https://crrev.com/5786c78151d756dbc8458e4e616d81a7c86b0a13
Cr-Commit-Position: refs/heads/master@{#413727}
Patch Set 1 #
Messages
Total messages: 19 (7 generated)
Are you able to run this test locally? I get the following:
$ ninja -C out/Release blimp_browsertests
$ testing/xvfb.py out/Release out/Release/blimp_browsertests
Additional test environment:
CHROME_DEVEL_SANDBOX=/usr/local/sbin/chrome-devel-sandbox
LANG=en_US.UTF-8
Command: ./blimp_browsertests
IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
Using sharding settings from environment. This is shard 0/1
Using 16 parallel jobs.
[ RUN ] EngineBrowserTest.LoadUrl
[1/1] EngineBrowserTest.LoadUrl (191 ms)
Retrying 1 test (retry #1)
[ RUN ] EngineBrowserTest.LoadUrl
[2/2] EngineBrowserTest.LoadUrl (323 ms)
Retrying 1 test (retry #2)
[ RUN ] EngineBrowserTest.LoadUrl
[3/3] EngineBrowserTest.LoadUrl (258 ms)
Retrying 1 test (retry #3)
[ RUN ] EngineBrowserTest.LoadUrl
[4/4] EngineBrowserTest.LoadUrl (323 ms)
1 test failed:
EngineBrowserTest.LoadUrl
(../../blimp/engine/browser_tests/engine_browsertest.cc:62)
lgtm
not lgtm Let me try to run it locally before you submit.
On 2016/08/17 17:17:45, Kevin M wrote: > not lgtm > > Let me try to run it locally before you submit. yes that's the point of my message, I can't run it successfully.
Description was changed from ========== Convert blimp_browsertests to run on Swarming. tools/mb/mb.py run //out/Release -j 500 -m chromium.linux -b "Linux Builder" blimp_browsertests R=haibinlu@chromium.org,kmarshall@chromium.org BUG=98637 ========== to ========== Convert blimp_browsertests to run on Swarming. tools/mb/mb.py run //out/Release -j 500 -m chromium.linux -b "Linux Builder" blimp_browsertests R=kmarshall@chromium.org BUG=98637 ==========
maruel@chromium.org changed reviewers: - haibinlu@chromium.org
I think I fixed the breakage here (https://codereview.chromium.org/2256363003/), can you patch the CL and see if things work for you?
On 2016/08/19 01:29:27, Kevin M wrote: > I think I fixed the breakage here (https://codereview.chromium.org/2256363003/), > can you patch the CL and see if things work for you? Well, could you patch in BUILD.gn from this CL into yours? It'd be faster. It's not like I'm working on blimp. :) Once your CL is committed I'll take a look again. BTW, tests shouldn't be running on the CI if there is no pre-commit testing.
The CQ bit was checked by kmarshall@chromium.org
lgtm Browser tests are fixed, so I'll lgtm & submit this.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was checked by maruel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Convert blimp_browsertests to run on Swarming. tools/mb/mb.py run //out/Release -j 500 -m chromium.linux -b "Linux Builder" blimp_browsertests R=kmarshall@chromium.org BUG=98637 ========== to ========== Convert blimp_browsertests to run on Swarming. tools/mb/mb.py run //out/Release -j 500 -m chromium.linux -b "Linux Builder" blimp_browsertests R=kmarshall@chromium.org BUG=98637 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Convert blimp_browsertests to run on Swarming. tools/mb/mb.py run //out/Release -j 500 -m chromium.linux -b "Linux Builder" blimp_browsertests R=kmarshall@chromium.org BUG=98637 ========== to ========== Convert blimp_browsertests to run on Swarming. tools/mb/mb.py run //out/Release -j 500 -m chromium.linux -b "Linux Builder" blimp_browsertests R=kmarshall@chromium.org BUG=98637 Committed: https://crrev.com/5786c78151d756dbc8458e4e616d81a7c86b0a13 Cr-Commit-Position: refs/heads/master@{#413727} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5786c78151d756dbc8458e4e616d81a7c86b0a13 Cr-Commit-Position: refs/heads/master@{#413727} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
