Handle SIGSEGV in BrowserTestBase

content/public/test/browser_test_base.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/test/browser_test_base.h"
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 53 matching lines @@
 #if defined(OS_POSIX)
 // On SIGTERM (sent by the runner on timeouts), dump a stack trace (to make
 // debugging easier) and also exit with a known error code (so that the test
 // framework considers this a failure -- http://crbug.com/57578).
 // Note: We only want to do this in the browser process, and not forked
 // processes. That might lead to hangs because of locks inside tcmalloc or the
 // OS. See http://crbug.com/141302.
 static int g_browser_process_pid;
 static void DumpStackTraceSignalHandler(int signal) {
   if (g_browser_process_pid == base::GetCurrentProcId()) {
-    logging::RawLog(logging::LOG_ERROR,
-                    "BrowserTestBase signal handler received SIGTERM. "
-                    "Backtrace:\n");
+    std::string message("BrowserTestBase received signal: ");
+    message += strsignal(signal);
+    message += ". Backtrace:\n";
+    logging::RawLog(logging::LOG_ERROR, message.c_str());
     base::debug::StackTrace().Print();
   }
   _exit(128 + signal);
 }
 #endif  // defined(OS_POSIX)
 
 void RunTaskOnRendererThread(const base::Closure& task,
                              const base::Closure& quit_task) {
   task.Run();
   BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, quit_task);
@@ skipping 223 matching lines @@
 }
 
 void BrowserTestBase::TearDown() {
 }
 
 void BrowserTestBase::ProxyRunTestOnMainThreadLoop() {
 #if defined(OS_POSIX)
   if (handle_sigterm_) {
     g_browser_process_pid = base::GetCurrentProcId();
     signal(SIGTERM, DumpStackTraceSignalHandler);
+    signal(SIGSEGV, DumpStackTraceSignalHandler);

[Paweł Hajdan Jr., 2016/08/17 06:34:09]

Could you just move this and g_browser_process_pid assignment out of "if
(handle_sigterm_)" ?

[michaelpg, 2016/08/18 23:44:37]

Done.

   }
 #endif  // defined(OS_POSIX)
 
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableTracing)) {
     base::trace_event::TraceConfig trace_config(
         base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
             switches::kEnableTracing),
         base::trace_event::RECORD_CONTINUOUSLY);
     TracingController::GetInstance()->StartTracing(
@@ skipping 56 matching lines @@
   use_software_compositing_ = true;
 }
 
 bool BrowserTestBase::UsingOSMesa() const {
   base::CommandLine* cmd = base::CommandLine::ForCurrentProcess();
   return cmd->GetSwitchValueASCII(switches::kUseGL) ==
          gl::kGLImplementationOSMesaName;
 }
 
 }  // namespace content