chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc - Issue 2250473006: Settings to remap Backspace and Escape keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

Issue 2250473006: Settings to remap Backspace and Escape keys (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KeyboardRemapToCapsLockBackspace

Patch Set: nit: consistent ordering Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/events/event_rewriter.h ('K') | « chrome/browser/resources/options/chromeos/keyboard_overlay.html ('k') | chrome/common/pref_names.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc b/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

index edb82135564dff766c4c1086c829527042eb1378..104671e63b3e2473394e928769a292eafd3515ed 100644

--- a/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

@@ -47,6 +47,8 @@ const char* kDataValuesNames[] = {

"remapAltKeyToValue",

"remapCapsLockKeyToValue",

"remapDiamondKeyToValue",

+ "remapEscapeKeyToValue",

+ "remapBackspaceKeyToValue",

};

bool HasExternalKeyboard() {

@@ -92,6 +94,12 @@ void KeyboardHandler::GetLocalizedValues(

localized_strings->SetString("remapDiamondKeyToContent",

l10n_util::GetStringUTF16(

IDS_OPTIONS_SETTINGS_LANGUAGES_KEY_DIAMOND_KEY_LABEL));

+ localized_strings->SetString("remapBackspaceKeyToContent",

+ l10n_util::GetStringUTF16(

+ IDS_OPTIONS_SETTINGS_LANGUAGES_KEY_BACKSPACE_KEY_LABEL));

+ localized_strings->SetString("remapEscapeKeyToContent",

+ l10n_util::GetStringUTF16(

+ IDS_OPTIONS_SETTINGS_LANGUAGES_KEY_ESCAPE_KEY_LABEL));

localized_strings->SetString("sendFunctionKeys",

l10n_util::GetStringUTF16(

IDS_OPTIONS_SETTINGS_LANGUAGES_SEND_FUNCTION_KEYS));