chrome/browser/chromeos/preferences.cc - Issue 2250473006: Settings to remap Backspace and Escape keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/preferences.cc

Issue 2250473006: Settings to remap Backspace and Escape keys (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KeyboardRemapToCapsLockBackspace

Patch Set: nit: consistent ordering Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/events/event_rewriter.h ('K') | « chrome/browser/chromeos/events/event_rewriter_unittest.cc ('k') | chrome/browser/resources/options/chromeos/keyboard_overlay.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/preferences.cc

diff --git a/chrome/browser/chromeos/preferences.cc b/chrome/browser/chromeos/preferences.cc

index 33bffebba903cf1b812f6678a040de2bf22f0a82..eb1a9cca183051e59e1215c97a9bd745938e0e8a 100644

--- a/chrome/browser/chromeos/preferences.cc

+++ b/chrome/browser/chromeos/preferences.cc

@@ -256,8 +256,13 @@ void Preferences::RegisterProfilePrefs(

registry->RegisterIntegerPref(prefs::kLanguageRemapCapsLockKeyTo,

input_method::kCapsLockKey);

registry->RegisterIntegerPref(

- prefs::kLanguageRemapDiamondKeyTo,

- input_method::kControlKey,

+ prefs::kLanguageRemapEscapeKeyTo, input_method::kEscapeKey,

+ user_prefs::PrefRegistrySyncable::SYNCABLE_PRIORITY_PREF);

+ registry->RegisterIntegerPref(

+ prefs::kLanguageRemapBackspaceKeyTo, input_method::kBackspaceKey,

+ user_prefs::PrefRegistrySyncable::SYNCABLE_PRIORITY_PREF);

+ registry->RegisterIntegerPref(

+ prefs::kLanguageRemapDiamondKeyTo, input_method::kControlKey,

user_prefs::PrefRegistrySyncable::SYNCABLE_PRIORITY_PREF);

// The following pref isn't synced since the user may desire a different value

// depending on whether an external keyboard is attached to a particular