Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: chrome/browser/chromeos/events/event_rewriter.cc

Issue 2250473006: Settings to remap Backspace and Escape keys (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KeyboardRemapToCapsLockBackspace
Patch Set: nit: consistent ordering Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/events/event_rewriter.cc
diff --git a/chrome/browser/chromeos/events/event_rewriter.cc b/chrome/browser/chromeos/events/event_rewriter.cc
index 709e8b3838fc6e4caf00eafbd2eab740c3b8277f..16b7ad47059087742b08e426917f35bad6bf9d5b 100644
--- a/chrome/browser/chromeos/events/event_rewriter.cc
+++ b/chrome/browser/chromeos/events/event_rewriter.cc
@@ -111,11 +111,11 @@ const struct ModifierRemapping {
ui::VKEY_CAPITAL}},
{ui::EF_NONE,
input_method::kEscapeKey,
- nullptr,
+ prefs::kLanguageRemapEscapeKeyTo,
{ui::EF_NONE, ui::DomCode::ESCAPE, ui::DomKey::ESCAPE, ui::VKEY_ESCAPE}},
{ui::EF_NONE,
input_method::kBackspaceKey,
- nullptr,
+ prefs::kLanguageRemapBackspaceKeyTo,
{ui::EF_NONE, ui::DomCode::BACKSPACE, ui::DomKey::BACKSPACE,
ui::VKEY_BACK}},
{ui::EF_NONE,
@@ -777,6 +777,14 @@ bool EventRewriter::RewriteModifierKeys(const ui::KeyEvent& key_event,
remapped_key =
GetRemappedKey(prefs::kLanguageRemapAltKeyTo, *pref_service);
break;
+ case ui::DomCode::ESCAPE:
+ remapped_key =
+ GetRemappedKey(prefs::kLanguageRemapEscapeKeyTo, *pref_service);
+ break;
+ case ui::DomCode::BACKSPACE:
+ remapped_key =
+ GetRemappedKey(prefs::kLanguageRemapBackspaceKeyTo, *pref_service);
+ break;
default:
break;
}

Powered by Google App Engine
This is Rietveld 408576698