content/browser/gpu/browser_gpu_channel_host_factory.cc - Issue 2250473005: content: Fix Context creation logic in ContextProviderFactoryImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/browser_gpu_channel_host_factory.cc

Issue 2250473005: content: Fix Context creation logic in ContextProviderFactoryImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: run the callback once, fix comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/gpu/browser_gpu_channel_host_factory.h ('k') | content/browser/renderer_host/compositor_impl_android.h » ('j') | content/browser/renderer_host/context_provider_factory_impl_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/gpu/browser_gpu_channel_host_factory.cc

diff --git a/content/browser/gpu/browser_gpu_channel_host_factory.cc b/content/browser/gpu/browser_gpu_channel_host_factory.cc

index 345ad2a4f423957b4e60b9751365084ef4b0a464..edc79849be8198d31addc3b18ee311b125a85cb8 100644

--- a/content/browser/gpu/browser_gpu_channel_host_factory.cc

+++ b/content/browser/gpu/browser_gpu_channel_host_factory.cc

@@ -212,8 +212,13 @@ void BrowserGpuChannelHostFactory::Initialize(bool establish_gpu_channel) {

void BrowserGpuChannelHostFactory::Terminate() {

DCHECK(instance_);

- delete instance_;

+ // Reset the |instance_| first so we don't receive any more Gpu Channel

+ // initialization requests as we run the existing callbacks.

+ BrowserGpuChannelHostFactory* current_instance = instance_;

instance_ = NULL;

+ delete current_instance;

}

BrowserGpuChannelHostFactory::BrowserGpuChannelHostFactory()