DevTools: Repick execution context when frames are loaded

DevTools: Repick execution context when frames are loaded

BUG=626415
Committed: https://crrev.com/92c30798b17477dbeadc7deca52f0a992fbcc6c9
Cr-Commit-Position: refs/heads/master@{#412426}

[einbinder, 2016-08-15 20:31:45]

einbinder@chromium.org changed reviewers:
+ eostroukhov@chromium.org, pfeldman@chromium.org

[einbinder, 2016-08-15 20:31:45]

einbinder@chromium.org changed required reviewers:
+ pfeldman@chromium.org

[einbinder, 2016-08-15 20:31:46]

ptal

[pfeldman, 2016-08-16 16:28:28]

https://codereview.chromium.org/2250473002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js
(right):

https://codereview.chromium.org/2250473002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js:19:
targetManager.addModelListener(WebInspector.RuntimeModel,
WebInspector.RuntimeModel.Events.ResortExecutionContexts,
this._onResortExecutionContexts, this);
ExecutionContextOrderChanged.

https://codereview.chromium.org/2250473002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js:172:
if (this._shouldSwitchToContext(executionContext)) {
_onExecutionContextCreated has similar semantics. Please extract.

https://codereview.chromium.org/2250473002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right):

https://codereview.chromium.org/2250473002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:137:
resortExecutionContexts: function()
fireExecutionContextOrderChanged

[einbinder, 2016-08-16 17:36:09]

ptal

https://codereview.chromium.org/2250473002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js
(right):

https://codereview.chromium.org/2250473002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js:19:
targetManager.addModelListener(WebInspector.RuntimeModel,
WebInspector.RuntimeModel.Events.ResortExecutionContexts,
this._onResortExecutionContexts, this);
On 2016/08/16 at 16:28:28, pfeldman wrote:
> ExecutionContextOrderChanged.

Done.

https://codereview.chromium.org/2250473002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js:172:
if (this._shouldSwitchToContext(executionContext)) {
On 2016/08/16 at 16:28:28, pfeldman wrote:
> _onExecutionContextCreated has similar semantics. Please extract.

Done.

https://codereview.chromium.org/2250473002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right):

https://codereview.chromium.org/2250473002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:137:
resortExecutionContexts: function()
On 2016/08/16 at 16:28:28, pfeldman wrote:
> fireExecutionContextOrderChanged

Done.

[pfeldman, 2016-08-16 18:26:46]

lgtm. you probably want a test to go with it!

[einbinder, 2016-08-16 20:24:16]

On 2016/08/16 at 18:26:46, pfeldman wrote:
> lgtm. you probably want a test to go with it!

I can do a weak test that just tests if the events are firing correctly, but I
don't know how to test the ResourceTreeModel loading the frames after the
execution contexts.

[pfeldman, 2016-08-16 22:59:34]

On 2016/08/16 20:24:16, einbinder wrote:
> On 2016/08/16 at 18:26:46, pfeldman wrote:
> > lgtm. you probably want a test to go with it!
> 
> I can do a weak test that just tests if the events are firing correctly, but I
> don't know how to test the ResourceTreeModel loading the frames after the
> execution contexts.

3000 tests a year!

[einbinder, 2016-08-16 23:45:17]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2016-08-16 23:46:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 02:23:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-17 02:26:46]

Description was changed from

==========
DevTools: Repick execution context when frames are loaded

BUG=626415
==========

to

==========
DevTools: Repick execution context when frames are loaded

BUG=626415

Committed: https://crrev.com/92c30798b17477dbeadc7deca52f0a992fbcc6c9
Cr-Commit-Position: refs/heads/master@{#412426}
==========

[commit-bot: I haz the power, 2016-08-17 02:26:48]

Patchset 3 (id:??) landed as
https://crrev.com/92c30798b17477dbeadc7deca52f0a992fbcc6c9
Cr-Commit-Position: refs/heads/master@{#412426}