tests/language/regress_27104_test.dart - Issue 2250433007: Type check field initializers in the correct context.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/language/regress_27104_test.dart

Issue 2250433007: Type check field initializers in the correct context. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 library regress_25609_lib1;	5 // Regression test for issue 27401
	Siggi Cherem (dart-lang) 2016/08/18 14:46:09 Let's rename the file and add some description her Let's rename the file and add some description here about what this is providing coverage for. That way we can understand the test without having to lookup the bug (also the bug doesn't have much details about what the problem is). Suggestion: - filename: typecheck_multifield_declaration_test.dart - Description: Checks that we can correctly typecheck multi-variable declarations on fields and top-levels. This is also a regression test for Issue 27401. Johnni Winther 2016/08/19 07:46:16 Done. Show quoted text On 2016/08/18 14:46:09, Siggi Cherem (dart-lang) wrote: > Let's rename the file and add some description here about what this is providing > coverage for. That way we can understand the test without having to lookup the > bug (also the bug doesn't have much details about what the problem is). > > Suggestion: > - filename: typecheck_multifield_declaration_test.dart > - Description: Checks that we can correctly typecheck multi-variable > declarations on fields and top-levels. This is also a regression test for Issue > 27401. Done.
6	6

7 import 'regress_25609_lib2.dart';	7 class A {}

8	8

9 typedef Bar Foo(int y);	9 A a = new A(), b = new A();
	Siggi Cherem (dart-lang) 2016/08/18 14:46:09 Also - do we want to test it out on class fields t Also - do we want to test it out on class fields too? E.g.: class B { A x = new A(), y = new A(); } main() => [new B().x, new B().y] ? Johnni Winther 2016/08/19 07:46:16 Done. Show quoted text On 2016/08/18 14:46:09, Siggi Cherem (dart-lang) wrote: > Also - do we want to test it out on class fields too? E.g.: > > class B { > A x = new A(), y = new A(); > } > > main() => [new B().x, new B().y] > > ? Done.
10	10

	11 main() => [a, b];

OLD	NEW

« no previous file with comments | « pkg/compiler/lib/src/typechecker.dart ('k') | no next file » | no next file with comments »