blimp/client/session/blimp_client_session.cc - Issue 2250433006: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/session/blimp_client_session.cc

Issue 2250433006: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/feature/compositor/blimp_input_manager.cc ('k') | blimp/engine/feature/geolocation/engine_geolocation_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/session/blimp_client_session.cc

diff --git a/blimp/client/session/blimp_client_session.cc b/blimp/client/session/blimp_client_session.cc

index 0cdcd12a5534ad9e2f837c9ea0c588380f37c2d7..35593bf1422d31af96f7c8ae4572136f53c9a4b6 100644

--- a/blimp/client/session/blimp_client_session.cc

+++ b/blimp/client/session/blimp_client_session.cc

@@ -47,9 +47,8 @@ BlimpClientSession::BlimpClientSession(const GURL& assigner_endpoint)

options.message_loop_type = base::MessageLoop::TYPE_IO;

io_thread_.StartWithOptions(options);

net_components_.reset(new ClientNetworkComponents(

- base::WrapUnique(new CrossThreadNetworkEventObserver(

- weak_factory_.GetWeakPtr(),

- base::SequencedTaskRunnerHandle::Get()))));

+ base::MakeUnique<CrossThreadNetworkEventObserver>(

+ weak_factory_.GetWeakPtr(), base::SequencedTaskRunnerHandle::Get())));

assignment_source_.reset(new AssignmentSource(

assigner_endpoint, io_thread_.task_runner(), io_thread_.task_runner()));

@@ -105,9 +104,8 @@ void BlimpClientSession::OnAssignmentConnectionAttempted(

const Assignment& assignment) {}

void BlimpClientSession::RegisterFeatures() {

- thread_pipe_manager_ = base::WrapUnique(

- new ThreadPipeManager(io_thread_.task_runner(),

- net_components_->GetBrowserConnectionHandler()));

+ thread_pipe_manager_ = base::MakeUnique<ThreadPipeManager>(

+ io_thread_.task_runner(), net_components_->GetBrowserConnectionHandler());

// Register features' message senders and receivers.

tab_control_feature_->set_outgoing_message_processor(