blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc - Issue 2250433006: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc

Issue 2250433006: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/feature/compositor/blimp_compositor_manager_unittest.cc ('k') | blimp/client/feature/compositor/blimp_input_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc

diff --git a/blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc b/blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc

index 437269ad5fec17b7835a92618eb653dbfcc1f032..ad158afb28ff87b992c12135f1924f131cfb9bed 100644

--- a/blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc

+++ b/blimp/client/feature/compositor/blimp_gpu_memory_buffer_manager.cc

@@ -147,8 +147,7 @@ BlimpGpuMemoryBufferManager::CreateGpuMemoryBufferFromHandle(

return nullptr;

return base::WrapUnique<gfx::GpuMemoryBuffer>(new GpuMemoryBufferImpl(

- size, format,

- base::WrapUnique(new base::SharedMemory(handle.handle, false)),

+ size, format, base::MakeUnique<base::SharedMemory>(handle.handle, false),

handle.offset, handle.stride));

}